Conversation
This was referenced Mar 23, 2023
Contributor
Author
|
Current dependencies on/for this PR:
This comment was auto-generated by Graphite. |
Contributor
Author
|
Current dependencies on/for this PR:
This comment was auto-generated by Graphite. |
wjuan-mob
changed the title
wjuan-mob
changed the title
wjuan-mob
force-pushed
the
feature/add_new_memo_with_data_types
branch
2 times, most recently
from
962582a to
c5b043b
Compare
Add new AuthenticatedSenderWithData and DestinationWithData memo types per MCIP#60 Clean up match statement and add new memo with data types to sample paykit memo handler Removing with data types due to discussion on mcip/60 Update dependencies to get cd to pass Update dependencies to get cd to pass
Add new AuthenticatedSenderWithData and DestinationWithData memo types per MCIP#60 Clean up match statement and add new memo with data types to sample paykit memo handler Removing with data types due to discussion on mcip/60 Update dependencies to get cd to pass Update dependencies to get cd to pass
wjuan-mob
force-pushed
the
feature/add_new_memo_with_data_types
branch
from
edf0043 to
5958a24
Compare
wjuan-mob
requested review from
cbeck88,
dolanbernard,
jcape and
nick-mobilecoin
and removed request for
nick-mobilecoin
cbeck88
reviewed
Mar 29, 2023
cbeck88
approved these changes
Mar 29, 2023
dolanbernard
approved these changes
Apr 4, 2023
NotGyro
pushed a commit
that referenced
this pull request
Apr 7, 2023
…nation function (#3275) * Refactor compute authenticated sender memo and compute destination memo. Add new AuthenticatedSenderWithData and DestinationWithData memo types per MCIP#60 Clean up match statement and add new memo with data types to sample paykit memo handler Removing with data types due to discussion on mcip/60 Update dependencies to get cd to pass Update dependencies to get cd to pass * Refactor compute authenticated sender memo and compute destination memo. Add new AuthenticatedSenderWithData and DestinationWithData memo types per MCIP#60 Clean up match statement and add new memo with data types to sample paykit memo handler Removing with data types due to discussion on mcip/60 Update dependencies to get cd to pass Update dependencies to get cd to pass
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactor out a shared compute authenticated sender and compute destination function
Motivation
Having a shared compute authenticated sender function and compute destination function is useful for #3200 so that the rth_memo_builder can use them to create the custom memos.