Track failed tx proposals in consensus#3208
Merged
Conversation
Contributor
Author
|
Current dependencies on/for this PR: This comment was auto-generated by Graphite. |
3 tasks
NotGyro
force-pushed
the
milliec/03-07-Track_failed_tx_proposals_in_consensus
branch
from
08fe3f6 to
cf0b095
Compare
awygle
approved these changes
Mar 29, 2023
Contributor
awygle
left a comment
awygle
left a comment
There was a problem hiding this comment.
This seems fine as far as it goes. I assume this tracking will actually be used in a follow-on PR?
samdealy
approved these changes
Mar 29, 2023
Co-authored-by: Sam Dealy <33067698+samdealy@users.noreply.github.com>
…s for Instant and Duration
NotGyro
force-pushed
the
milliec/03-07-Track_failed_tx_proposals_in_consensus
branch
from
c9ecddf to
13376da
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
tx_proposal_failurestoClientSessionTrackingfail_tx_proposal()onClientSessionTrackingsession.fail_tx_proposal(now)when a tx proposal is found to be invalid.Motivation
This will be used to track how many failed tx proposals have been sent recently, so that bad connections can be dropped, to prevent attacks and harmful behavior from buggy clients. See: #2977
Future Work