Skip to content

refactor: splitting devicekit-ios into h264 repository#47

Merged
gmegidish merged 7 commits into
mainfrom
refactor-devicekit-h264-goes-to-another-repo
May 24, 2026
Merged

refactor: splitting devicekit-ios into h264 repository#47
gmegidish merged 7 commits into
mainfrom
refactor-devicekit-h264-goes-to-another-repo

Conversation

@gmegidish
Copy link
Copy Markdown
Member

No description provided.

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 24, 2026

Caution

Review failed

Pull request was closed or merged during review

Walkthrough

This PR removes screen-sharing broadcast infrastructure and associated video/audio codec packages from the project. The BroadcastUploadExtension app extension—which captured screen samples and encoded them to H.264 video with Opus audio over TCP—is deleted entirely, along with the h264-codec and opus-codec Swift packages that supported it. The Xcode project is simplified by removing the extension target, its build phases, codec package references, and codec product dependencies. The CI workflow no longer runs SwiftLint as a separate job, SwiftLint configuration is updated to lint fewer paths, the Makefile adds a help target, and the project's license changes from Apache 2.0 to Functional Source License 1.1 with a future Apache 2.0 grant.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Description check ❓ Inconclusive No pull request description was provided by the author, making it impossible to assess whether it relates to the changeset. Add a description explaining why these components are being removed/split, what the new repository structure will be, and how this affects users or developers.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title 'refactor: splitting devicekit-ios into h264 repository' accurately describes the main change: removing H.264 codec, Opus audio codec, and BroadcastUploadExtension components to separate them into another repository.
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch refactor-devicekit-h264-goes-to-another-repo

Comment @coderabbitai help to get the list of available commands and usage tips.

@gmegidish gmegidish merged commit 2410477 into main May 24, 2026
4 of 5 checks passed
@gmegidish gmegidish deleted the refactor-devicekit-h264-goes-to-another-repo branch May 24, 2026 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant