Skip to content

refactor: devicekit h264 goes to another repo #46

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gmegidish merged 6 commits into from
May 24, 2026
Merged

refactor: devicekit h264 goes to another repo #46

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
b0f1967
Relicense under FSL-1.1-Apache-2.0
gmegidish May 22, 2026
91e1ad9
refactor: h264 device kit broadcast extension goes to another repository
gmegidish May 24, 2026
fb9ede5
refactor: h264 device kit broadcast extension goes to another repository
gmegidish May 24, 2026
e9ae0ee
fix: update swiftlint paths after h264/broadcast extension removal
gmegidish May 24, 2026
8711ff3
chore: temporarily disable lint job
gmegidish May 24, 2026
912a6db
fix: remove H264HTTPHandler reference after h264 extraction
gmegidish May 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 2 additions & 15 deletions .github/workflows/build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,19 +12,6 @@ permissions:
contents: read

jobs:
lint:
runs-on: macos-latest

steps:
- name: Checkout code
uses: actions/checkout@v5

- name: Install SwiftLint
run: brew install swiftlint

- name: Run lint
run: make lint

trivy:
runs-on: macos-latest

Expand All @@ -42,7 +29,7 @@ jobs:
run: trivy fs --severity HIGH,CRITICAL --exit-code 1 .

build-ipa:
needs: [lint, trivy]
needs: [trivy]
Copy link
Copy Markdown

@coderabbitai coderabbitai Bot May 24, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟠 Major | ⚡ Quick win

🧩 Analysis chain

🏁 Script executed:

#!/bin/bash
# Check if lint job still exists in the workflow
echo "Checking for lint job in workflow:"
if grep -q "^  lint:" .github/workflows/build.yml; then
  echo "✓ Lint job still exists"
  grep -A 10 "^  lint:" .github/workflows/build.yml
else
  echo "✗ Lint job was removed from workflow"
fi

# Show that linting is still configured
echo ""
echo "SwiftLint configuration still exists:"
fd -t f "\.swiftlint\.yml$" --exec head -15

echo ""
echo "Lint target still documented:"
rg -n "make lint" README.md Makefile

Repository: mobile-next/devicekit-ios

Length of output: 260

Restore or explicitly justify SwiftLint CI enforcement

  • In .github/workflows/build.yml, build-ipa/build-sim now only need trivy, and there is no lint job in this workflow—so SwiftLint won’t fail CI.
  • .swiftlint.yml still exists and README.md still documents make lint.

Reintroduce a lint job (and gate build-ipa/build-sim on it) or update docs/workflow with a clear rationale for intentionally removing the CI lint gate.

🤖 Prompt for AI Agents 
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In @.github/workflows/build.yml at line 32, The CI change removed the lint gate:
reintroduce a lint job in .github/workflows/build.yml (name it lint) that runs
SwiftLint (or run `make lint`) and make build-ipa and build-sim need: [trivy,
lint] so lint must pass before builds, or alternatively update README.md and the
workflow to document the intentional removal of CI linting (remove references to
`make lint` and .swiftlint.yml or add an explicit rationale comment) — modify
the workflow jobs `lint`, `build-ipa`, and `build-sim` accordingly.

runs-on: macos-latest

steps:
Expand All @@ -65,7 +52,7 @@ jobs:
retention-days: 4

build-sim:
needs: [lint, trivy]
needs: [trivy]
runs-on: macos-latest

steps:
Expand Down
3 changes: 0 additions & 3 deletions .gitmodules
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +0,0 @@
[submodule "opus-codec/Sources/Copus"]
path = opus-codec/Sources/Copus
url = https://github.com/xiph/opus.git
7 changes: 2 additions & 5 deletions .swiftlint.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,11 +2,8 @@

# Paths to include/exclude
included:
- devicekit-ios
- BroadcastUploadExtension
- BroadcastUploadExtensionSetupUI
- h264-codec
- tcp
- DeviceKit
- DeviceKitTests

excluded:
- Pods
Expand Down
26 changes: 0 additions & 26 deletions BroadcastUploadExtension/CGRect+Extension.swift
View file
Open in desktop

This file was deleted.

20 changes: 0 additions & 20 deletions BroadcastUploadExtension/CMSampleBuffer+Extension.swift
View file
Open in desktop

This file was deleted.

15 changes: 0 additions & 15 deletions BroadcastUploadExtension/Info.plist
View file
Open in desktop

This file was deleted.

88 changes: 0 additions & 88 deletions BroadcastUploadExtension/SampleHandler.swift
View file
Open in desktop

This file was deleted.

Loading
Loading