Merge pull request #10861 from apple/ahusain/releaseNotes-71.3.3 - #7
Open
mo74m3ed wants to merge 521 commits into
Open
Merge pull request #10861 from apple/ahusain/releaseNotes-71.3.3#7mo74m3ed wants to merge 521 commits into
mo74m3ed wants to merge 521 commits into
Conversation
…t in most workloads that create metaclusters
apple#10068) * make status json report desired role count (log, resolver, proxies...) regardless whether user sets it explicitly * make proxies calculation simpler * Add comment for DatabaseConfiguration
…(Cherry-pick apple#10041 to snowflake/release-71.3)) (apple#10042) * Fix for correctness failures when issuing duplicate requests Add comments; Disable failure injection in Snap test * Add Snapshot tests which are clean when fault injection is disabled in Snaptest. * Remove snapshot restarting tests in from_7.1.0_until_71.2.0
…owflake/release-71.3) (apple#10064)
…snowflake/release-71.3) (apple#10071)
…ot test failure. (apple#10078) * Downgrade "inaccurate shard estimate" consistency check to warning, not test failure. We know that the hash function used for sampling keys is biased and oversamples. The fix is non-trivial, since we can't straightforwardly change the sampling function for existing FDB databases. Thus, we downgrade this particular test failure to a warning. * Disable test failure entirely, since it will retry and fail again. Change the existing log message to a warning, so we at least have some indiciation in the logs that we hit the biased shard estimate issue.
…#10070 to snowflake/release-71.3) (apple#10084)
…idate it when loading the entry from the cluster. (apple#10085)
…ble rocksdb related tests (apple#10082)
…ple#10089 to snowflake/release-71.3) (apple#10102)
…to snowflake/release-71.3) (apple#10092)
…to snowflake/release-71.3) (apple#10097)
…#10073 to snowflake/release-71.3) (apple#10099) * Write storage_metadata for TSS and add test for it (Cherry-Pick apple#10073 to snowflake/release-71.3) * populate storage metadata for tss * add metadata check to quiesent consistency check * check storage metadata and storage server interface in the same transaction
…herry-Pick apple#10058 to snowflake/release-71.3) (apple#10101)
…we have Python 2 files and a few files written externally. Add external files as exclusions to the precommit checks. (apple#10094)
…tdown improvements found along the way. (Cherry-Pick apple#10109 to snowflake/release-71.3) (apple#10131)
… used during commit protection in Java
to snowflake/release-71.3) (apple#10072)
…… (Cherry-Pick apple#10106 to snowflake/release-71.3) (apple#10113)
(cherry picked from commit cdef452)
…10108) (apple#10115) Description 'Type' is a reserved keywork for TraceEvent, RESTKmsConnector was usng 'Type' to log CipherDetail or BlobMetadata type information. It causes 'fdbserver' binary to crash/restart Patch addresses the usage to ensure TraceEvent compatibility is maintained. Further, it proposes following test improvements: 1. Fix existing unit-test that 'should' have caught this issue. 2. Add more test coverage. 3. Add CODE_PROBE to ensure relevant corner cases are validated. Testing RESTKmsConnectorUnit (cherry picked from commit 7e872c4)
…ecause otherwise we could delete our coordinated state (apple#10136)
…py (Cherry-Pick apple#10076 to snowflake/release-71.3) (apple#10139)
…herry-Pick apple#10157 to snowflake/release-71.3) (apple#10158)
* fix: Non-storage processes were not being checked for locality exclusions fix: Data distribution when not detect a newly added process was locality excluded fix: RemoveServerSafely did not wait for processes to be excluded before killing them when excluding localities * fix: do not allow locality based excludes if they cannot exclude the required addresses * fix: do not allow rebootAndDelete when doing locality based excludes because it changes the processId of a process
* Prevent Status actor from bubbling up timeout error Description Patch addresses occurrences where Status.actor ends up bubbling timeout error up to the ClusterController causing recovery to be triggered when ClusterGetStatus timeout for some reason. Testing devRunCorrectness - 100K * Update fdbserver/Status.actor.cpp Co-authored-by: A.J. Beamon <aj.beamon@snowflake.com> --------- Co-authored-by: A.J. Beamon <aj.beamon@snowflake.com>
…ectly deal with re-aligning keys after downsample (apple#10794)
…pple#10811) * Normalize clear costs for quota throttler * Track cost of point clears
Description Release notes - snowflake 71.3.4 Testing
…r a request (apple#10808) * FDBCORE-5950: Ensure exponential backoff while refreshing KMS URLs for a request Description KMS server(s) outage could last for longer times, RESTKmsConnector follow exponential-backoff semantics when retrying request to same KMS server, however, it doesn't follow exponential backoff semantics when attempting to retry request after refreshing KMS URLs by reading on-disk discovery file. Patch addresses the concern by ensuring request follow exponential backoff semantics for above mentioned scenario. Testing devRunCorrectness - 100K 20230824-141642-ahusain-6351198682ff45b7 * Update the initial and max delays as KNOBs Description Testing
…ake/release-71.3) (apple#10830) * Add trace details about over-replicated shard and range count * Fix count refresh
…) (apple#10832) * EaR: Handle KMS timeout in storage server and commit proxy * EaR: reduce KMS request timeout
Description KMS health check monitor is instrumental in determing FDB <-> KMS connectivity issues (no connection or flakiness). Patch lower the check interval to be under FDB commit timeout to get assist diagnosing such issues. The change do translate to increased request to KMS, however, the health-check asks for FDB system keyspace encryption key, it would be hitting cache on KMS server all the time (unless a KMS server got replaced and the first read is a miss) Testing devRunCorrectness - 100K
Co-authored-by: Ata E Husain Bohra <ata.husain@snowflake.com>
Description Bump version to 71.3.5 Testing
… compatibility with previous 71.3 patches (apple#10847)
Description Release notes for snowflake/71.3.3 Testing
DatabaseContext currently leaks memory by creating `Counter`s with unique IDs on construction. Each status json call creates a new `DatabaseContext` object, causing a memory leak over time.
Description Bump snowflake/release-71.3 from 71.3.5 -> 71.3.6 Testing
* Release notes for snowflake/release-71.3.5 Description Release notes for snowflake/release-71.3.5a Testing
Description Release notes - snowflake/release-71.3.6 Testing
Release notes 71.3.3
Owner
Author
|
@copilot resolve the merge conflicts on this branch. |
Copilot stopped work on behalf of
mo74m3ed due to an error
August 13, 2026 01:53
Owner
Author
|
@copilot resolve the merge conflicts on this branch. |
1 similar comment
Owner
Author
|
@copilot resolve the merge conflicts on this branch. |
Copilot stopped work on behalf of
mo74m3ed due to an error
August 13, 2026 01:53
Copilot stopped work on behalf of
mo74m3ed due to an error
August 13, 2026 01:53
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PLEASE DELETE THIS TEMPLATE WHEN YOU POST YOUR PR FOR REVIEW
Please describe:
We encourage AI-assisted review. Save your diff:
Then review it with a prompt like:
END OF TEMPLATE TO DELETE