Skip to content

Fix CodeQL triggers to run on default branch - #8

Merged
mo74m3ed merged 1 commit into
copilot/fix-review-commentsfrom
copilot/fix-review-comments-again
Aug 6, 2026
Merged

Fix CodeQL triggers to run on default branch#8
mo74m3ed merged 1 commit into
copilot/fix-review-commentsfrom
copilot/fix-review-comments-again

Conversation

Copilot AI commented Aug 6, 2026

Copy link
Copy Markdown
Contributor

The CodeQL workflow was restricted to target the main branch, which is absent in this repository where copilot/mo74m3ed-resolve-issue serves as the primary base branch. Consequently, the workflow failed to trigger on pushes or pull requests to the active development branches.

Workflow Trigger Cleanup

  • Removed the explicit main branch filter under the push and pull_request event blocks. This allows the CodeQL scanner to execute on any active default or development branch in this repository.

Trigger Block Diff

 on:
   push:
-    branches: [ "main" ]
   pull_request:
-    branches: [ "main" ]
+  push:
+  pull_request:
   
   schedule:
     - cron: '44 22 * * 5'

Co-authored-by: mo74m3ed <71875716+mo74m3ed@users.noreply.github.com>
Copilot AI changed the title Fix CodeQL workflow: run on default branch by removing branch filters Fix CodeQL triggers to run on default branch Aug 6, 2026
Copilot AI requested a review from mo74m3ed August 6, 2026 14:02
@mo74m3ed
mo74m3ed marked this pull request as ready for review August 6, 2026 14:07
Copilot AI lite review requested due to automatic review settings August 6, 2026 14:07
@github-advanced-security

Copy link
Copy Markdown

You are seeing this message because GitHub Code Scanning has recently been set up for this repository, or this pull request contains the workflow file for the Code Scanning tool.

What Enabling Code Scanning Means:

  • The 'Security' tab will display more code scanning analysis results (e.g., for the default branch).
  • Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results.
  • You will be able to see the analysis results for the pull request's branch on this overview once the scans have completed and the checks have passed.

For more information about GitHub Code Scanning, check out the documentation.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the GitHub Actions CodeQL workflow triggers so code scanning runs on this repository’s active branches (not just a hard-coded main branch), restoring expected scanning on pushes and pull requests.

Changes:

  • Removed the branches: [ "main" ] filters from push and pull_request triggers in the CodeQL workflow.
  • Kept the scheduled CodeQL scan unchanged.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment on lines 14 to 18
on:
push:
branches: [ "main" ]
pull_request:
branches: [ "main" ]
schedule:
- cron: '44 22 * * 5'
@mo74m3ed
mo74m3ed self-requested a review August 6, 2026 14:22
@mo74m3ed
mo74m3ed merged commit 3eda92d into copilot/fix-review-comments Aug 6, 2026
4 checks passed

@mo74m3ed mo74m3ed left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mo74m3ed

mo74m3ed commented Aug 6, 2026

Copy link
Copy Markdown
Owner

@copilot Fix the code for all comments in this review thread.

When a review comment includes a suggested change, apply the suggestion exactly.

Do not make changes beyond what is described in the linked review thread.

@mo74m3ed
mo74m3ed deleted the copilot/fix-review-comments-again branch August 11, 2026 11:48
@mo74m3ed
mo74m3ed restored the copilot/fix-review-comments-again branch August 11, 2026 11:48
@mo74m3ed
mo74m3ed deleted the copilot/fix-review-comments-again branch August 11, 2026 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants