This repository was archived by the owner on Mar 30, 2019. It is now read-only.
support for utf8 filenames(must not re-encode to utf8)#3
Open
kanryu wants to merge 1 commit intomnafees:masterfrom
Open
support for utf8 filenames(must not re-encode to utf8)#3kanryu wants to merge 1 commit intomnafees:masterfrom
kanryu wants to merge 1 commit intomnafees:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ZipFileInfo64 have flags which means 'General purpose flags'.
That contains 'Utf8Names' flag should be 0x0800 .
if this flag is on, the filename should not be system localed, but UTF-8.
To see https://github.com/Medium/phantomjs-1/blob/master/src/qt/qtbase/src/gui/text/qzip.cpp