Skip to content

Develop - #42

Open
mmorel-35 wants to merge 35 commits into
masterfrom
develop
Open

Develop#42
mmorel-35 wants to merge 35 commits into
masterfrom
develop

Conversation

@mmorel-35

Copy link
Copy Markdown
Owner

No description provided.

Copilot AI and others added 20 commits May 28, 2026 23:43
@coveralls

coveralls commented May 28, 2026

Copy link
Copy Markdown

Coverage Report for CI Build 27001553801

Coverage decreased (-6.2%) to 87.271%

Details

  • Coverage decreased (-6.2%) from the base build.
  • Patch coverage: 578 uncovered changes across 25 files (2646 of 3224 lines covered, 82.07%).
  • 1 coverage regression across 1 file.

Uncovered Changes

Top 10 Files by Coverage Impact Changed Covered %
internal/checkers/require_len.go 464 374 80.6%
internal/checkers/http_multiple.go 296 236 79.73%
internal/checkers/wrong_t.go 273 226 82.78%
internal/checkers/error_first.go 266 222 83.46%
internal/checkers/require_error.go 241 202 83.82%
internal/checkers/helpers_import.go 160 124 77.5%
internal/checkers/eventually_with_t.go 173 138 79.77%
internal/checkers/negated_assert.go 160 132 82.5%
internal/checkers/redundant_assert.go 152 125 82.24%
internal/checkers/helpers_basic_type.go 50 25 50.0%
Total (35 files) 3224 2646 82.07%

Coverage Regressions

1 previously-covered line in 1 file lost coverage.

File Lines Losing Coverage Coverage
internal/checkers/helpers_encoded.go 1 90.0%

Coverage Stats

Coverage Status
Relevant Lines: 5994
Covered Lines: 5231
Line Coverage: 87.27%
Coverage Strength: 1.01 hits per line

💛 - Coveralls

@mmorel-35

Copy link
Copy Markdown
Owner Author

@copilot
Fix golangci-lint issues

Copilot AI commented May 28, 2026

Copy link
Copy Markdown

@copilot
Fix golangci-lint issues

Fixed the golangci-lint issues in commit d9c522e.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@mmorel-35
mmorel-35 marked this pull request as ready for review May 29, 2026 08:07
@mmorel-35

Copy link
Copy Markdown
Owner Author

@copilot resolve the merge conflicts in this pull request

Copilot AI commented May 31, 2026

Copy link
Copy Markdown

@copilot resolve the merge conflicts in this pull request

Resolved the merge conflicts in commit 4302fb7 and a5e72e7. The three conflicting files were:

  • README.md: Kept the redundant-assert row and preserved require-error with 🤏 from the develop branch.
  • internal/analysisutil/file.go: Used master's correct v < 2 check in PkgBaseName (preventing v1 from being incorrectly stripped as a version suffix), while keeping the concise comment style.
  • internal/analysisutil/file_test.go: Used the comprehensive table-driven tests from develop, adding master's v1 test case to TestPkgBaseName.

All tests pass.

@mmorel-35

Copy link
Copy Markdown
Owner Author

@copilot ,
Fix lint issues

Copilot AI commented May 31, 2026

Copy link
Copy Markdown

@copilot ,
Fix lint issues

Fixed in commit 13b0490. The single lint issue was in internal/checkers/require_len.go: replaced []byte(fmt.Sprintf(...)) with fmt.Appendf(nil, ...) as flagged by the modernize linter. golangci-lint now reports 0 issues.

@mmorel-35

Copy link
Copy Markdown
Owner Author

@copilot ,
Fix lint issues

Copilot AI commented Jun 1, 2026

Copy link
Copy Markdown

@copilot ,
Fix lint issues

Fixed in commit 6736dd3. The intrange linter flagged a traditional for loop in internal/checkers/require_len.go — replaced it with for i := range currCallIndex. golangci-lint now reports 0 issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants