Skip to content

Log packet length, RSSI and SNR when readData() fails #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mmmorks wants to merge 1 commit into
base: staging/meshcore-dev
Choose a base branch
from
Open

Log packet length, RSSI and SNR when readData() fails #15

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 15 additions & 1 deletion src/helpers/radiolib/RadioLibWrappers.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,7 +133,21 @@ int RadioLibWrapper::recvRaw(uint8_t* bytes, int sz) {
if (len > sz) { len = sz; }
int err = _radio->readData(bytes, len);
if (err != RADIOLIB_ERR_NONE) {
MESH_DEBUG_PRINTLN("RadioLibWrapper: error: readData(%d)", err);
// Signal quality of the packet that just failed. A CRC mismatch (-7) is
// the common case and says nothing on its own about *why*: a packet at
// the edge of the demodulator and one lost to a collision both land
// here. The modem's packet-status registers are written whether or not
// the CRC passed, so this reads the same values a successful receive
// would report, at no extra SPI cost -- enough to tell a failure
// distribution sitting on the SF's SNR floor apart from one spread
// across strong signals.
//
// SNR is scaled by 4 rather than truncated because the threshold this
// is meant to resolve is a fraction of a dB wide, and %f is not
// portable across every platform this file builds for. Same quarter-dB
// convention as Packet::_snr.
MESH_DEBUG_PRINTLN("RadioLibWrapper: error: readData(%d) len=%d rssi=%d snr4=%d",
err, len, (int)getLastRSSI(), (int)(getLastSNR() * 4));
len = 0;
n_recv_errors++;
} else {
Expand Down
Loading