fix(desktop): strip preamble tags with attributes (<user-profile note=...>)#61
Merged
Merged
Conversation
…=...>) (#52 follow-up) The preamble stripper matched bare <user-profile>/<recalled-memory> tags, but the real personalization block is <user-profile note="..."> (harness/personal/recall.ts) with an attribute, so it leaked into the session title and the first transcript bubble (reported). Match the opening tag + any attributes (<tag\b[^>]*>) for user-profile and recalled-memory, mirroring the active-skill pattern. Verified live against the real polluted session: title 'I really like andy's custard...' (was '<user-profile note="What we have learn...') and the first transcript bubble are both clean. 11 sessions tests pass (1 new attribute-form regression test); tsc clean. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #55. The injected
<user-profile>block actually carries anoteattribute (<user-profile note="What we have learned about the user…">), but the stripper matched a bare<user-profile>, so it leaked into the session title and the first transcript bubble (reported).Fix: match the opening tag plus any attributes (
<tag\b[^>]*>) foruser-profileandrecalled-memory, mirroring theactive-skillpattern.Verified live against the real session: title is now
I really like andy's custard…(was<user-profile note="What we have learn…) and the first transcript bubble is clean. 11 sessions tests pass (added an attribute-form regression test); tsc clean.🤖 Generated with Claude Code