Skip to content

Update logging for gpt-oss-20b#447

Draft
suachong wants to merge 3 commits intomlcommons:masterfrom
suachong:master
Draft

Update logging for gpt-oss-20b#447
suachong wants to merge 3 commits intomlcommons:masterfrom
suachong:master

Conversation

@suachong
Copy link
Contributor

No description provided.

@github-actions
Copy link

github-actions bot commented Feb 23, 2026

MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅

Copy link
Contributor

@ShriyaRishab ShriyaRishab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ShriyaRishab
Copy link
Contributor

@suachong - do you have RCP epochs for at least one of the batch sizes?

REQ: AT_LEAST_ONE
CHECK:
- "'epoch_num' in v['metadata']"
ATLEAST_ONE_CHECK: "(v['value'] <= 3.34) and v['value'] > 0.0" No newline at end of file
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add the rest of the parameters also but don't add a specific check?
Similar to this - https://github.com/mlcommons/logging/blob/master/mlperf_logging/compliance_checker/training_6.0.0/open_llama31_405b.yaml

ShriyaRishab
ShriyaRishab previously approved these changes Feb 26, 2026
@ShriyaRishab
Copy link
Contributor

@suachong please address the merge conflicts and open issues so we can merge it today

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants