feat: add json.registry.package option - #7
Merged
Conversation
Allow configuring the package of the generated JsonAdapterRegistry via the compiler arg -Ajson.registry.package=<package>. Without the option, falls back to the first adapter's package (sorted alphabetically). This fixes registry package inconsistencies when @JsonRecord classes span multiple packages (e.g. io.daftech.binance vs io.daftech.exchange.model). Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
json.registry.packagecompiler option to configure the package of the generatedJsonAdapterRegistryMotivation
When
@JsonRecordclasses span multiple packages (e.g.io.daftech.binanceandio.daftech.exchange.model), the registry package was non-deterministic. This option allows projects to explicitly set it.Usage