Skip to content

security: pin GitHub Actions to reviewed SHAs - #15

Merged
mkarson1997 merged 2 commits into
mainfrom
security/pin-actions-sha
Sep 9, 2026
Merged

security: pin GitHub Actions to reviewed SHAs#15
mkarson1997 merged 2 commits into
mainfrom
security/pin-actions-sha

Conversation

@mkarson1997

@mkarson1997 mkarson1997 commented Sep 9, 2026

Copy link
Copy Markdown
Owner

What changed

  • pin checkout and setup-node in the Node 22/24 + PostgreSQL CI matrix
  • upgrade/pin CodeQL from mutable v3 tags to the reviewed v4 commit
  • preserve the existing aggregate CI Gate, lockfile install, typecheck, tests and build behavior

Why

FlowForge is one of the flagship infrastructure repositories. Its validation and security analysis should not depend on mutable GitHub Action tags.

Merge only after the Node/PostgreSQL matrix, CI Gate, CodeQL and SonarQube Cloud are green.

Summary by Sourcery

Pin CI and CodeQL GitHub Actions to reviewed SHAs to make repository validation and security analysis reproducible.

Enhancements:

  • Pin GitHub Actions used by CI and CodeQL workflows to reviewed commit SHAs, including upgrading CodeQL to v4 while preserving existing validation behavior.

CI:

  • Secure the Node.js/PostgreSQL matrix and CodeQL workflows against mutable action tags.

Copilot AI lite review requested due to automatic review settings September 9, 2026 10:16
@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, you can upgrade your account or add credits to your account and enable them for code reviews in your settings.

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry @mkarson1997, you've used your own review budget of 250,000 diff characters for the last 7 days.

You can request another review in 2 days by commenting @sourcery-ai review. Upgrade to get a review now.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@sourcery-ai

sourcery-ai Bot commented Sep 9, 2026

Copy link
Copy Markdown
Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

This security-focused change removes mutable GitHub Actions references from CI and CodeQL by pinning them to reviewed commit SHAs, while preserving the existing validation behavior and requiring the Node/PostgreSQL matrix, CI Gate, CodeQL, and SonarQube Cloud checks to pass.

File-Level Changes

Change Details Files
Pin CI workflow actions to immutable, reviewed commit SHAs while retaining version comments for traceability.
  • Pin checkout and setup-node in the Node 22/24 and PostgreSQL matrix.
  • Keep the existing lockfile install, typecheck, test, build, and aggregate CI Gate flow unchanged.
.github/workflows/ci.yml
Upgrade CodeQL workflow actions from mutable v3 tags to the reviewed v4 commit.
  • Pin checkout to the reviewed SHA.
  • Pin both CodeQL initialization and analysis actions to the same reviewed v4 SHA.
.github/workflows/codeql.yml

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@sonarqubecloud

sonarqubecloud Bot commented Sep 9, 2026

Copy link
Copy Markdown

@mkarson1997
mkarson1997 merged commit 2613a1d into main Sep 9, 2026
7 checks passed
@mkarson1997
mkarson1997 deleted the security/pin-actions-sha branch September 9, 2026 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants