Skip to content

ci: add stable aggregate quality gate - #14

Merged
mkarson1997 merged 5 commits into
mainfrom
chore/stable-ci-gate
Sep 5, 2026
Merged

ci: add stable aggregate quality gate#14
mkarson1997 merged 5 commits into
mainfrom
chore/stable-ci-gate

Conversation

@mkarson1997

@mkarson1997 mkarson1997 commented Sep 5, 2026

Copy link
Copy Markdown
Owner

Adds a stable CI Gate check that succeeds only when the full Node verification matrix succeeds. This gives repository rulesets a durable required-check target even when supported Node versions change later.

Summary by Sourcery

Add a durable aggregate CI check for repository rulesets as the supported Node verification matrix evolves.

New Features:

  • Add a stable CI Gate check that reports the outcome of the complete Node verification matrix.

Enhancements:

  • Scope workflow permissions to the verification job and grant the aggregate gate no repository permissions.

CI:

  • Ensure the CI Gate runs regardless of matrix results and fails whenever verification does not succeed.

Copilot AI lite review requested due to automatic review settings September 5, 2026 11:56

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@sourcery-ai

sourcery-ai Bot commented Sep 5, 2026

Copy link
Copy Markdown
Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

The workflow now exposes a stable CI Gate check that runs after the full verification matrix and succeeds only when that matrix completes successfully, providing a durable required-check target for repository rulesets.

Flow diagram for the stable CI quality gate

flowchart TD
    Verify["verify matrix"] --> Gate["CI Gate"]
    Gate --> Result{VERIFY_RESULT == success}
    Result -->|yes| Pass["CI Gate passes"]
    Result -->|no| Fail["CI Gate fails"]
    Pass --> Ruleset["Repository ruleset required check"]
    Fail --> Ruleset
Loading

File-Level Changes

Change Details Files
Add a durable aggregate CI status check for repository rulesets.
  • Add an always-run gate job that depends on the verification matrix.
  • Propagate the matrix result into a shell check and fail unless it is successful.
  • Keep the check name stable as CI Gate while supported Node versions can evolve.
.github/workflows/ci.yml

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've reviewed your changes and they look great!

Sourcery assessment

Approved.


Sourcery is free for open source - if you like our reviews please consider sharing them ✨

@sonarqubecloud

sonarqubecloud Bot commented Sep 5, 2026

Copy link
Copy Markdown

@mkarson1997
mkarson1997 merged commit 5aa0967 into main Sep 5, 2026
6 checks passed
@mkarson1997
mkarson1997 deleted the chore/stable-ci-gate branch September 5, 2026 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants