Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR fixes an issue with the GitHub Actions CI status check when using a matrix strategy by adding a new job to inspect the results of dependent jobs.
- Introduces a "ci-check" job that depends on the "ci" job.
- Uses conditional steps to exit with a failure status if any job fails or is cancelled, and with success if all jobs pass or are skipped.
Comments suppressed due to low confidence (1)
.github/workflows/test.yml:71
- [nitpick] Add a comment explaining the purpose of using 'if: always()' with this job to ensure reviewers understand that it is meant to always run regardless of previous job statuses.
if: always()
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix: PR status check cannot fetch correct status from CI workflow using matrix strategy.