Skip to content

fix: prevent dual-value submission in Add Potential Link modal #94

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
deacon-mp wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: prevent dual-value submission in Add Potential Link modal #94

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 17 additions & 2 deletions src/components/operations/AddPotentialLinkModal.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,6 +99,21 @@ const potentialLinksToAdd = computed(() => {

const canSelectAgent = computed(() => !props.agent || !props.agent.paw);

// When a custom value is typed, deselect all fact checkboxes for that fact name
function onCustomValueInput(factName) {
selectedPotentialLinkFacts.value[factName].facts.forEach((fact) => {
fact.selected = false;
});
}

// When a fact checkbox is selected, clear the custom value for that fact name
function onFactSelected(factName) {
const hasSelected = selectedPotentialLinkFacts.value[factName].facts.some((fact) => fact.selected);
if (hasSelected) {
selectedPotentialLinkFacts.value[factName].customValue = "";
}
}

const operationSourceFacts = computed(() => props.operation?.source?.facts || []);

onMounted(async () => {
Expand Down Expand Up @@ -246,10 +261,10 @@ const selectPotentialLink = async (link) => {
v-tooltip="`There are currently empty fact templates. You can still add this link but it may not run properly.`")
font-awesome-icon(icon="fa-exclamation-triangle")
.control
input.input(v-model="selectedPotentialLinkFacts[factName].customValue" type="text" placeholder="Enter a custom value")
input.input(v-model="selectedPotentialLinkFacts[factName].customValue" type="text" placeholder="Enter a custom value" @input="onCustomValueInput(factName)")
div(v-for="fact in selectedPotentialLinkFacts[factName].facts")
label.checkbox
input.mr-2(type="checkbox" v-model="fact.selected")
input.mr-2(type="checkbox" v-model="fact.selected" @change="onFactSelected(factName)")
span.mr-2 {{ fact.value }}
span.tag.mr-2 {{ fact.origin }}

Expand Down
Loading