Repository navigation
Feature/firefox api key copy - #38
Merged
Merged
Conversation
|
Caution The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (3)
🚧 Files skipped from review as they are similar to previous changes (3)
📝 WalkthroughWalkthroughThe PR redesigns project identity presentation, extracts API-key copying into a reusable controller, adds browser and rendering coverage, updates application UI assertions, and makes rate-limit TTL tests wall-clock aware. ChangesProject UI rendering
API-key copy controller
Rate-limit TTL test updates
Estimated code review effort: 4 (Complex) | ~45 minutes Sequence Diagram(s)sequenceDiagram
participant ProjectDetail
participant SecretController
participant Clipboard
participant SecretPanel
ProjectDetail->>SecretController: showSecret(result.secret)
SecretController->>SecretPanel: display secret and reset status
SecretController->>Clipboard: copyText(secret)
Clipboard-->>SecretController: return copy result
SecretController->>SecretPanel: update status and cleanup timers
Possibly related PRs
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #38 +/- ##
==========================================
+ Coverage 76.29% 76.35% +0.06%
==========================================
Files 38 38
Lines 10736 10736
Branches 1653 1653
==========================================
+ Hits 8191 8198 +7
+ Misses 1943 1938 -5
+ Partials 602 600 -2 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
mitchins
marked this pull request as ready for review
July 22, 2026 03:31
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
🧹 Nitpick comments (2)
smolrouter/templates/request_detail.html (1)
322-325: 📐 Maintainability & Code Quality | 🔵 Trivial | 💤 Low valueUse the canonical value in the tooltip, or drop the title.
title="Identity"just repeats the label;request_identity.canonicalwould be more useful here.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@smolrouter/templates/request_detail.html` around lines 322 - 325, Update the Identity detail span in the request template to use request_identity.canonical as the title value instead of the redundant “Identity” label, or remove the title attribute. Preserve the displayed canonical value and surrounding conditional rendering.tests/unit/test_api_key_copy_js.py (1)
12-23: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick winSurface Node script output on failure for easier CI debugging.
check=True+capture_output=Truemeans a failing Node assertion raisesCalledProcessError, whose default message doesn't include the captured stdout/stderr — the actual assertion failure text gets swallowed in CI logs.♻️ Proposed fix: include captured output in the failure message
repository = Path(__file__).resolve().parents[2] - subprocess.run( + result = subprocess.run( [node, script], cwd=repository, - check=True, text=True, capture_output=True, ) + assert result.returncode == 0, result.stdout + result.stderr🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@tests/unit/test_api_key_copy_js.py` around lines 12 - 23, Update the test_browser_behaviour helper to preserve captured Node output when subprocess.run raises CalledProcessError: catch the failure, include its stdout and stderr in the raised failure message, and retain successful execution and Node-missing skip behavior.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In `@smolrouter/templates/request_detail.html`:
- Around line 322-325: Update the Identity detail span in the request template
to use request_identity.canonical as the title value instead of the redundant
“Identity” label, or remove the title attribute. Preserve the displayed
canonical value and surrounding conditional rendering.
In `@tests/unit/test_api_key_copy_js.py`:
- Around line 12-23: Update the test_browser_behaviour helper to preserve
captured Node output when subprocess.run raises CalledProcessError: catch the
failure, include its stdout and stderr in the raised failure message, and retain
successful execution and Node-missing skip behavior.
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: a037ea52-9265-420f-aef9-26c09989f1cc
📒 Files selected for processing (12)
smolrouter/static/vendor/api-key-copy.jssmolrouter/templates/client_dashboard.htmlsmolrouter/templates/index.htmlsmolrouter/templates/project_detail.htmlsmolrouter/templates/projects.htmlsmolrouter/templates/request_detail.htmltests/js/test_api_key_copy.jstests/js/test_project_ui_rendering.jstests/unit/test_api_key_copy_js.pytests/unit/test_app.pytests/unit/test_project_key_manager.pytests/unit/test_request_rate_limits.py
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by CodeRabbit