Proposal for method to handle Math operations for dist_lognormal (with additional tests)#148
Open
drgomulka wants to merge 2 commits into
Open
Proposal for method to handle Math operations for dist_lognormal (with additional tests)#148drgomulka wants to merge 2 commits into
drgomulka wants to merge 2 commits into
Conversation
enables multiplication and division between dist_lognormal classes and scalars
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I wrote
Ops.dist_lognormal()to extend the functionality of thedist_lognormalclass. This is inspired by the methodOps.dist_normal(), but written with very explicit if-statements for every case. Tests were added to verify proper functioning. NAMESPACE was modified by hand to contain the new method (devtools::document()touches too many files).