chore: remove orphaned uv.lock with no tool.uv config or uv install path - #331
Merged
joryirving merged 1 commit intoSep 14, 2026
Merged
Conversation
The uv.lock at the repo root is dead: pyproject.toml declares only [project] and [tool.ruff] (no [tool.uv] resolver), and CI installs via `pip install -r requirements.txt -r requirements-dev.txt` with no `uv sync` / `uv pip install` anywhere. The lockfile pinned only the package itself at a stale version with no transitive dependencies, and its absence in the build path meant nothing consumed it. Delete the file rather than adding a [tool.uv] section, matching the project's actual pip-based install path. A follow-up grep across .github/, README.md, CHANGELOG.md, AGENTS.md, and Dockerfile finds no uv.lock references to update. Fixes #328 Signed-off-by: Saffron <263493777+itsmiso-ai@users.noreply.github.com>
![its-saffron[bot]](https://avatars.githubusercontent.com/in/3901073?s=60&v=4){kind=small}
There was a problem hiding this comment.
AI Automated Review
Full PR review.
Analysis engine: MiniMax-M2.7@https://litellm.jory.dev/v1 (anthropic) — primary route
Recommendation: Approve
This PR directly and completely addresses the linked issue PR 328 by deleting the orphaned uv.lock file.
Change Summary
- File deleted:
uv.lock(8 lines removed) - The deleted lockfile contained only a self-reference to
foreman-dispatch-bridgeat version 0.7.0 with no transitive dependencies — confirming the "dead lockfile" characterization from the issue.
Linked Issue Fit
| Acceptance Criterion | Status |
|---|---|
uv.lock is deleted, change committed and pushed |
✅ Verified in diff |
No [tool.uv] section added to pyproject.toml |
✅ Not in diff — expected outcome |
Grep for uv.lock in workflows/docs finds no references needing update |
✅ Repository impact scan confirms zero hits for "uv.lock" |
The issue's ask — "Remove the orphaned uv.lock from the repository root, since pyproject.toml has no [tool.uv] section and CI installs through pip install -r requirements.txt — is quoted verbatim and satisfied exactly.
CI Checks
Both test and docker checks passed successfully.
Standards Compliance
- AGENTS.md convention: Issues must state the ask in one imperative sentence and name expected file paths. Issue PR 328 satisfies both.
- No repository conventions are violated by this change.
Findings
No findings.
joryirving
deleted the
foreman/wl-misospace-foreman-dispatch-bridge-328/issue-328
branch
September 14, 2026 12:19
Merged
joryirving
pushed a commit
that referenced
this pull request
Sep 14, 2026
…st and auto-bump it on release (#332) Replace the hard-coded pyproject.toml version (stale at 0.7.0 while .release-please-manifest.json had reached 0.9.0 — the reopened class of #174, which a one-time bump in v0.8.x had already failed to prevent) with 0.9.0, and switch release-please-config.json from release-type "simple" to "python": the python strategy's PyProjectToml updater rewrites [project].version in the same "release: X.Y.Z" PR as the manifest bump, and no other version-bearing files exist in this repo for it to touch. uv.lock, the second stale self-pin (0.1.0), was already removed in #331. Add tests/test_release_version_sync.py so CI fails whenever the pyproject version drifts from .release-please-manifest.json or the release-type regresses to a strategy that does not update pyproject.toml, closing the recurrence path this drift class kept reopening. Fixes #330 Signed-off-by: Saffron <263493777+itsmiso-ai@users.noreply.github.com> Co-authored-by: Saffron <263493777+itsmiso-ai@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes the orphaned uv.lock file from the repository root as it is not used by the build process or project configuration.
Fixes #328
Opened by foreman on review GO (workload wl-misospace-foreman-dispatch-bridge-328).