Support creating specialized vector/matrix functions#3
Merged
Conversation
158589b to
4c870f1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fvecNandmatMxNboth exist as statically defined types when a programmer writes their Haven code. This is fine, but it made it difficult to imagine building custom libraries for future development work.Consider something like ML code, where we might want to have tensors of varying lengths. The current approach requires the library implementor to either pre-specialize all the possible shapes or have some sort of code generation. Not great!
This PR instead adds specialization hole capability, where
fvec?andmat?can be provided as parameters. These are specialized at compile time. There are a few compile-time constants (.dimon vectors,.cols/.rowson matrices) that present the "real" shape once automatically specialized. A compile-time assertion in the form of@assertnow also gives implementors the ability to validate the input parameters statically.Also, functions using specialization holes will infer their return types automatically.