Open
Conversation
Member
|
Nice thanks for the PR! We don’t use oidc internally so I can merge this and release to see if it fixes the issues. |
simonprev
reviewed
Mar 19, 2026
simonprev
reviewed
Mar 19, 2026
simonprev
approved these changes
Mar 19, 2026
Author
|
Made all requested changes |
Co-authored-by: Simon Prévost <simonprevost@gmail.com>
a326489 to
319ea4a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Migrated custom OIDC auth provider to more modern ueberauth_oidcc
Note that:
OIDC_ISSUERas new implementation appends .well-known by itselfOIDC_DISCOVERY_URIby stripping additional pathI have zero experience with Elixir so I apologize in advance if I made something wrong.
Also sorry that I didn't open issue beforehand, I've initially planned this PR as a fix for #489