Skip to content

Migrate to ueberauth_oidcc#500

Open
AbsurdlySuspicious wants to merge 3 commits intomirego:masterfrom
AbsurdlySuspicious:oidc-fix-gh
Open

Migrate to ueberauth_oidcc#500
AbsurdlySuspicious wants to merge 3 commits intomirego:masterfrom
AbsurdlySuspicious:oidc-fix-gh

Conversation

@AbsurdlySuspicious
Copy link
Copy Markdown

@AbsurdlySuspicious AbsurdlySuspicious commented Mar 18, 2026

Migrated custom OIDC auth provider to more modern ueberauth_oidcc

Note that:

  • This introduces new env var OIDC_ISSUER as new implementation appends .well-known by itself
    • But my patch tries to be backwards compatible with previous OIDC_DISCOVERY_URI by stripping additional path
  • New implementation has more strong validation, some of idP`s my stop working because of this

I have zero experience with Elixir so I apologize in advance if I made something wrong.
Also sorry that I didn't open issue beforehand, I've initially planned this PR as a fix for #489

@simonprev
Copy link
Copy Markdown
Member

Nice thanks for the PR! We don’t use oidc internally so I can merge this and release to see if it fixes the issues.

@AbsurdlySuspicious
Copy link
Copy Markdown
Author

Made all requested changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

OIDC is crashing docker container

2 participants