-
Notifications
You must be signed in to change notification settings - Fork 0
Code Review! #19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
matiasgarcia91
wants to merge
59
commits into
review
Choose a base branch
from
development
base: review
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Code Review! #19
Changes from all commits
Commits
Show all changes
59 commits
Select commit
Hold shift + click to select a range
4aca700
installed material-ui and first setup of navbar
mir4cles 5208ae1
routing done with a tab bar
mir4cles 573ebc5
material-ui basic and standard implementation
mir4cles aa42a62
setup events.map with Cards
mir4cles caee391
event overview is fetching!
mir4cles 8b35bac
event details page with server data
mir4cles 3a6a8d6
teams and teamdetails fetched from server
mir4cles ffd55fa
Merge pull request #1 from mir4cles/events-fetching-and-mapping-from-…
mir4cles ced7033
add loggedIn status
mir4cles 0e78ffb
removed button from import
mir4cles 5f34f4e
Merge pull request #2 from mir4cles/feat-login-status-nav
mir4cles e74cff6
create event button on event page
mir4cles e994a33
form with useState without dispatch
mir4cles 8bf0a6b
dispatch form and send request to server
mir4cles afebd9c
Merge pull request #3 from mir4cles/feat-create-event
mir4cles 11b1a44
create event button fixed to bottom right
mir4cles 3f4f9d0
wider cards
mir4cles f8c049c
Merge pull request #4 from mir4cles/feat-events-overview
mir4cles d62c1af
show attendings in event overview
mir4cles 82bdc29
eventDetails show attendees as list
mir4cles e0eaf0c
attend event through event details
mir4cles 4ff345d
if rsvp already exists message will be shown
mir4cles d5e1b22
show cancel button if rsvp exists
mir4cles 27ad794
remove rsvp in state
mir4cles fb86e69
removed update_events from reducer
mir4cles ebdacc6
Merge pull request #5 from mir4cles/feat-rsvp
mir4cles 5415e5a
edit event details with no re-direct
mir4cles 7695bed
changes setMessage
mir4cles 61799d1
Merge pull request #6 from mir4cles/feat-editevent
mir4cles 1ff810a
Alert messagebox with proper props
mir4cles 16eb60c
Merge pull request #7 from mir4cles/feat-alert-messages
mir4cles 984200d
skeleton card for loading appState
mir4cles d0c8583
Merge pull request #8 from mir4cles/feat-loading
mir4cles 13c3483
event cards improvements
mir4cles 492a03c
event cards improvements
mir4cles 4f9d48d
Merge pull request #9 from mir4cles/feat-event-cards-v2
mir4cles 3bb84cc
event info with icons and event headers
mir4cles 84bbc66
Merge pull request #10 from mir4cles/feat-event-card-v3
mir4cles e671ad2
navbar without tabs
mir4cles b1c3471
Merge pull request #11 from mir4cles/feat-navbar-v2
mir4cles 01e2096
refactoring before deploy
mir4cles 4ad21f2
Merge pull request #12 from mir4cles/refactoring
mir4cles f7d40fd
Merge pull request #13 from mir4cles/development
mir4cles 3a6ecee
set some messages to showMessageWithTimeout
mir4cles 40c1381
Merge pull request #14 from mir4cles/minor-edits
mir4cles 784cbbe
readme
mir4cles 78d864b
readme
mir4cles be24b6c
Merge pull request #15 from mir4cles/master
mir4cles b4287d8
html title
mir4cles 121031f
Merge branch 'development' of github.com:mir4cles/teamMate-client int…
mir4cles 40729ec
Merge pull request #16 from mir4cles/development
mir4cles f0882e1
heroku api url in config
mir4cles f62e1b4
Merge pull request #17 from mir4cles/development
mir4cles 4a4fbdc
typo...
mir4cles a4b64c7
Merge pull request #18 from mir4cles/development
mir4cles 28f8608
Update README.md
mir4cles dd6dc9b
instructions on landing page
mir4cles c9ac9f3
Merge pull request #20 from mir4cles/landing-page
mir4cles af2a968
Merge pull request #21 from mir4cles/master
mir4cles File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,42 +1,49 @@ | ||
| # Frontend template | ||
| # teamMate | ||
|
|
||
| This is a simple react/redux/jwt template to start a project quickly | ||
| See the deployed site [here](https://modest-austin-b02609.netlify.app/) (loading times may vary due to database hosting). | ||
|
|
||
| ## Table of contents: | ||
|
|
||
| - **[Setup](#setup-how-to-use-this-template)** | ||
| - **[Create React App docs](#cra-docs)** | ||
| - **[About](#about-teamMate)** | ||
| - **[Getting started](#getting-started)** | ||
| - **[Built with](#built-with)** | ||
| - **[User stories and Wireframe](#User-stories-and-Wireframe)** | ||
|
|
||
| ## SETUP How to use this template | ||
| ## About teamMate | ||
|
|
||
| 1. Create a new project based on this template using the `Use this template` button | ||
| teamMate allows users to browse and host sport events. users can start a team, join an existing one or ride solo and attend private or public pick-up games. | ||
|
|
||
|  | ||
| ## Getting started | ||
|
|
||
| 2. Clone the app | ||
| 1. Clone the repo | ||
|
|
||
| ``` | ||
| git clone git@github.com:YOUR_GITHUB_NAME/YOUR_PROJECT_NAME.git | ||
| ``` | ||
| 2. cd into the repo on your computer. | ||
|
|
||
| 3. cd into your project | ||
| 3. Install dependencies | ||
|
|
||
| ``` | ||
| cd YOUR_PROJECT_NAME | ||
| $ npm install | ||
| ``` | ||
|
|
||
| 4. install dependencies | ||
| 4. Compile and run to run the app in a browser | ||
|
|
||
| ``` | ||
| npm install | ||
| $ npm run start | ||
| ``` | ||
|
|
||
| 5. Start development server with npm start | ||
| 4. If you like to use the server to see some data go [here](https://github.com/mir4cles/teamMate-server) and repeat steps 1,2,3,4 | ||
|
|
||
| ``` | ||
| npm start | ||
| ``` | ||
| 5. Let me know what you think. | ||
|
|
||
| ## Built With | ||
|
|
||
| - [Material Ui](https://material-ui.com/) | ||
| - [React](https://reactjs.org/) | ||
| - [Redux](https://redux.js.org/) | ||
| - [Codaisseur's React Redux Template](https://github.com/Codaisseur/express-template) | ||
|
|
||
| ## CRA docs | ||
| ## User stories and Wireframe | ||
|
|
||
| The normal Create React App docs can be found in [CRA_DOCS.md](./CRA_DOCS.md) | ||
| - [User storires](https://github.com/users/mir4cles/projects/1#column-9641210) | ||
| - [Wireframe of design](https://wireframepro.mockflow.com/view/teamMate-client-wireframe) | ||
| - [Database diagram](https://app.lucidchart.com/invitations/accept/9dd630e3-019a-48af-91cd-c250ff20fdec) |
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
as a style guide, i normally order my imports like: