terraform-cloud: cleanup and json schema#385
Open
jtdoepke wants to merge 1 commit into
Open
Conversation
Document five values that the templates already consume but were never declared in values.yaml: top-level `nameOverride` and `jobs`; `global.application`, `global.component`, `global.additionalLabels`; and `irsa.nameOverride`. All are optional with safe defaults, so there is no behavior change for existing consumers. Add a permissive `values.schema.json` that provides type validation for declared values while leaving room for unknown keys, so the dynamic `defaultVars` / `instances` / IRSA `vars` pass-throughs to Terraform modules remain unconstrained. Also fix two small inconsistencies discovered during the audit: - The `postgresql.terraform.defaultVars.enable_deletion_protection` comment was missing its `: bool` type hint; aligned with the matching comment in the other database modules. - `irsa.nameOverride` was commented under `irsa.terraform`, but the template reads `.Values.irsa.nameOverride` (top-level on the `irsa` block). Moved the documentation to the correct level. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
jtdoepke
force-pushed
the
terraform-cloud-cleanup-and-schema
branch
from
e27bbc5 to
03dd166
Compare
jtdoepke
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Document five values that the templates already consume but were never declared in values.yaml: top-level
nameOverrideandjobs;global.application,global.component,global.additionalLabels; andirsa.nameOverride. All are optional with safe defaults, so there is no behavior change for existing consumers.Add a permissive
values.schema.jsonthat provides type validation for declared values while leaving room for unknown keys, so the dynamicdefaultVars/instances/ IRSAvarspass-throughs to Terraform modules remain unconstrained.Also fix two small inconsistencies:
postgresql.terraform.defaultVars.enable_deletion_protectioncomment was missing its: booltype hint; aligned with the matching comment in the other database modules.irsa.nameOverridewas commented underirsa.terraform, but the template reads.Values.irsa.nameOverride(top-level on theirsablock). Moved the documentation to the correct level.