Skip to content

Improve drag-and-drop JS event emulation on Selenium 3 #408

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
aik099 merged 6 commits into from
Jan 20, 2025
Merged

Improve drag-and-drop JS event emulation on Selenium 3 #408

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
da03000
Fix D&D on Selenium 3
uuf6429 Jan 11, 2025
319602d
Merge remote-tracking branch 'origin/master' into bugfix/fix-dnd-on-s…
uuf6429 Jan 18, 2025
9fb6d9c
Replace selenium events with js events
uuf6429 Jan 19, 2025
c459427
Merge remote-tracking branch 'origin/master' into bugfix/fix-dnd-on-s…
uuf6429 Jan 19, 2025
984f354
Simplify code
uuf6429 Jan 19, 2025
2ca5e26
Change array syntax
uuf6429 Jan 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
53 changes: 22 additions & 31 deletions src/Selenium2Driver.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1025,44 +1025,35 @@ public function keyUp(string $xpath, $char, ?string $modifier = null)

public function dragTo(string $sourceXpath, string $destinationXpath)
{
$source = $this->findElement($sourceXpath);
$destination = $this->findElement($destinationXpath);
$source = $this->findElement($sourceXpath);
$target = $this->findElement($destinationXpath);

$this->getWebDriverSession()->moveto(array(
'element' => $source->getID()
));

$script = <<<JS
(function (element) {
var event = document.createEvent("HTMLEvents");
$this->getWebDriverSession()->moveto(array('element' => $source->getID()));
$this->getWebDriverSession()->buttondown();

event.initEvent("dragstart", true, true);
event.dataTransfer = {};
$this->executeJsOnElement($source, <<<'JS'
(function (sourceElement) {
window['__minkDragAndDropSourceElement'] = sourceElement;

element.dispatchEvent(event);
}({{ELEMENT}}));
JS;
$this->executeJsOnElement($source, $script);
sourceElement.dispatchEvent(new DragEvent('dragstart', {bubbles: true, cancelable: true}));
}({{ELEMENT}}));
JS
);

$this->getWebDriverSession()->buttondown();
if ($destination->getID() !== $source->getID()) {
$this->getWebDriverSession()->moveto(array(
'element' => $destination->getID()
));
}
$this->getWebDriverSession()->moveto(array('element' => $target->getID()));
$this->getWebDriverSession()->buttonup();

$script = <<<JS
(function (element) {
var event = document.createEvent("HTMLEvents");
$this->executeJsOnElement($target, <<<'JS'
(function (targetElement) {
var sourceElement = window['__minkDragAndDropSourceElement'];

event.initEvent("drop", true, true);
event.dataTransfer = {};

element.dispatchEvent(event);
}({{ELEMENT}}));
JS;
$this->executeJsOnElement($destination, $script);
sourceElement.dispatchEvent(new DragEvent('drag', {bubbles: true, cancelable: true}));
targetElement.dispatchEvent(new DragEvent('dragover', {bubbles: true, cancelable: true}));
targetElement.dispatchEvent(new DragEvent('drop', {bubbles: true, cancelable: true}));
sourceElement.dispatchEvent(new DragEvent('dragend', {bubbles: true, cancelable: true}));
}({{ELEMENT}}));
JS
);
}

public function executeScript(string $script)
Expand Down