Repository navigation
fix(worker): publish acknowledged group replies once - #66
Closed
mingtaojin wants to merge 1 commit into
Closed
mingtaojin wants to merge 1 commit into
mingtaojin wants to merge 1 commit into
Conversation
mingtaojin
force-pushed
the
fix/worker-group-reply-once
branch
from
November 20, 2026 08:19
82b8a93 to
72086d4
Compare
Owner
Author
|
Superseded by merged PR70 (d8ff23e). Current main uses WorkerChatTurn and stable assistant-item delivery in src/loop.ts and src/worker-chat-turn.ts; the old report/acknowledge_report API is no longer present. Validation on current main passed: test/runtime.test.ts 37/37 and test/project-runtime.test.ts 90/90. The obsolete branch and worktree remain preserved. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
A Worker can publish an intermediate group report and then publish a paraphrased ordinary final for the same answer. The two paths use different outbox identities, so the group shows two messages. This change adds an explicit, trusted acknowledgement for a report that already contains the answer.
What changed
Scope
Blast Radius
Worker report and final delivery paths gain one explicit action and a pinned task group target. Malformed or stale acknowledgement state fails open, so a legitimate final remains deliverable.
Verification
npm run checknode --import tsx --test test/project-runtime.test.tswith 114 passing tests.