Repository navigation
feat(config): use one private JSON credential file - #63
Closed
mingtaojin wants to merge 2 commits into
Closed
mingtaojin wants to merge 2 commits into
mingtaojin wants to merge 2 commits into
Conversation
mingtaojin
force-pushed
the
feat/single-json-config
branch
from
November 20, 2026 08:03
8f12b19 to
db3699f
Compare
Owner
Author
|
按项目所有者决定取消单 JSON 配置功能开发。PR #63 不合并,已知凭据泄露验证失败。 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Users need one private file that owns Agent Loop configuration and application credentials. This change reads Feishu credentials and the conditional GitHub token directly from JSON and removes the dotenv path.
What changed
tokenEnv,appIdEnv, andappSecretEnvwith direct credential fields and migrated CLI, Feishu helpers, examples, docs, and tests.--env-file. Provider and system environment inheritance remains available.Scope
config/example.json; ignored private config files remain the user's responsibility.mainhead. Live configuration migration, deployment, service restart, and merge remain outside this PR.Blast Radius
CLI startup, collection, Feishu pairing, verification, and progress publishing now require direct JSON credentials. Execution reload still replaces only
execution, so credential edits still require a restart.Verification
node --import tsx --test --test-concurrency=1 test/*.test.tspasses 731 tests after rebasing ontoac012384a2699ff394e603dece3402ee82413066.npm run check,npm run build,git diff --check, and the retained synthetic redaction repro pass. The repro covers CardKit payloads, URI encodings, object keys, and collision preservation.