Skip to content

feat(config): use one private JSON credential file - #63

Closed
mingtaojin wants to merge 2 commits into
mainfrom
feat/single-json-config
Closed

mingtaojin wants to merge 2 commits into
mainfrom
feat/single-json-config

Conversation

@mingtaojin

@mingtaojin mingtaojin commented Nov 20, 2026 •

Copy link
Copy Markdown
Owner

Why

Users need one private file that owns Agent Loop configuration and application credentials. This change reads Feishu credentials and the conditional GitHub token directly from JSON and removes the dotenv path.

What changed

  • Replaced tokenEnv, appIdEnv, and appSecretEnv with direct credential fields and migrated CLI, Feishu helpers, examples, docs, and tests.
  • Removed application dotenv loading and --env-file. Provider and system environment inheritance remains available.
  • Added credential redaction for errors, stored diagnostics, reports, dashboard JSON, snapshots, SSE, SDK logs, Feishu progress cards, and document progress writes. URI and form encodings and object keys are covered without substring collisions.

Scope

  • Covers the one-file workflow, conditional GitHub token requirement, pairing and verification helpers, and execution hot reload behavior.
  • The repository tracks only config/example.json; ignored private config files remain the user's responsibility.
  • The branch is rebased onto the current main head. Live configuration migration, deployment, service restart, and merge remain outside this PR.

Blast Radius

CLI startup, collection, Feishu pairing, verification, and progress publishing now require direct JSON credentials. Execution reload still replaces only execution, so credential edits still require a restart.

Verification

  • node --import tsx --test --test-concurrency=1 test/*.test.ts passes 731 tests after rebasing onto ac012384a2699ff394e603dece3402ee82413066.
  • The focused credential and Feishu progress suites pass 102 tests.
  • npm run check, npm run build, git diff --check, and the retained synthetic redaction repro pass. The repro covers CardKit payloads, URI encodings, object keys, and collision preservation.

@mingtaojin

Copy link
Copy Markdown
Owner Author

按项目所有者决定取消单 JSON 配置功能开发。PR #63 不合并,已知凭据泄露验证失败。

@mingtaojin mingtaojin closed this Nov 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant