Add Unit#value_in for bare-value conversion#37
Merged
Conversation
Unit#in returns a converted Unit and Unit#in! raises on a dimensionally incompatible target, but neither yields the raw number in the requested unit without a caller peeling off #value by hand. Add Unit#value_in(unit), which converts via #in! and returns the bare numeric value. An incompatible unit therefore raises TypeError rather than handing back a coerced number with residual dimensions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unit#inreturns a convertedUnitandUnit#in!raises on a dimensionally incompatible target, but neither yields the raw number in the requested unit without a caller peeling off#valueby hand.Unit#value_in(unit)converts via#in!and returns the bare numeric value, so an incompatible unit raisesTypeErrorrather than handing back a coerced number with residual dimensions.