Repository navigation
fix: Check watch caches against etcd once an hour - #846
Merged
Merged
Conversation
Milo keeps one watch cache per project per resource type, and since Kubernetes 1.34 each cache compares itself with etcd every 5 to 7.5 minutes through a full LIST. With tens of thousands of caches per server, those checks are nearly all of its etcd LISTs. Add --watch-cache-consistency-check-period, default one hour, and set the cacher's period from it before any storage is built, since each cache reads the period when its checker starts. The check stays on. Related to datum-cloud/infra#7071
scotwells
approved these changes
Oct 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Milo keeps one watch cache per project per resource type, and since Kubernetes 1.34 each compares itself with etcd every 5 to 7.5 minutes. Each check is a full LIST, so with tens of thousands of caches per server the checks are nearly all of its etcd LISTs. In production none has found a difference.
This adds a flag for the period, one hour by default, applied before any storage is built.
Test plan
Related to datum-cloud/infra#7071