IPClaim should not carry spec.ipFamily; the class owns the family #128

Activity

1. scotwells commented on Sep 23, 2026

   

   scotwells

   on Sep 23, 2026

   ContributorAuthor

   More actions

   Producer traced: this is the default path, not a stray caller

   The family-only claims come from NSO's networkinterfaceclaim_controller.go, and deliberately:

   if request.className == "" {
       ipClaim.Spec.IPFamily = ipamv1alpha1.IPFamily(request.family)
   }

   request.className is empty for every request built from NetworkInterfaceClaim.spec.ipFamilies:

   for _, family := range claim.Spec.IPFamilies {
       requests = append(requests, allocationRequest{
           discriminator: familyDiscriminator(family),
           family:        family,
       })
   }

   That field carries +kubebuilder:default={IPv6}, so every NetworkInterfaceClaim requests an address by family unless someone explicitly adds spec.addresses[].class — and that path is for extra addresses, flagged external: true. The six production claims are not stragglers; they are the currently-live interfaces. Their names confirm it: familyDiscriminator renders f-ipv6, classDiscriminator renders c-<class>, and all six end in -f-ipv6.

   Revised proposal

   Removing spec.ipFamily would break the primary address path for every workload on the platform. Withdrawing that part.

   The two defects are real and fixable without touching the contract:

   1. className and ipFamily are not mutually exclusive. A claim setting both has one silently ignored. Reject it at validation instead, so the field cannot contradict the class.
   2. Prefix-length validation reads the wrong family. Move the range check out of strategy validation into Create, where the class is resolved, so the bound comes from the class rather than defaulting to IPv4 when the claim says nothing.

   And status.classRef is now clearly worth adding rather than optional: the family-only path is the default path, so the resolved class is unrecorded on the majority of claims, not a handful.

   Retitling would be fair — this is no longer about removing the field.
2. scotwells commented on Sep 23, 2026

   

   scotwells

   on Sep 23, 2026

   ContributorAuthor

   More actions

   Implemented in #129, as the three fixes above minus the removal: spec.className is defaulted from the resolved class at create (PVC/StorageClass shape), a family that disagrees with the class is refused rather than ignored, and the IPv4-assuming prefix-length bound is gone. spec.ipFamily stays as the selector the defaulting needs, and status.classRef is no longer needed — the answer lands in spec.
3. scotwells commented on Sep 23, 2026

   

   scotwells

   on Sep 23, 2026

   ContributorAuthor

   More actions

   Superseded in direction by #130: the per-family default selector has never selected anything (zero IPv4 classes, claims or pools in either environment), so the follow-on is one default class per project and no spec.ipFamily on IPClaim at all. #129 still stands on its own — defaulting spec.className and the prefix-length bound are correct under either model, and refusing a mismatched family is the right guard until #130 lands.
4. scotwells

   closed this as completedin #129on Oct 29, 2026