Repository navigation
feat: Refuse zap development mode - #6
Merged
Merged
Conversation
Most controllers hard-code controller-runtime zap's development mode from the kubebuilder scaffold, so production logs console text at debug level and DPanic panics. AssertStandardLogger now refuses it in non-test source. Key changes: - flag a literal Development: true or UseDevMode(true) in zap options - explain the cost and point to --zap-devel for local runs - document the refusal in the README Closes #5 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
ecv
approved these changes
Oct 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #5.
AssertStandardLogger now fails on a literal Development: true or UseDevMode(true) in controller-runtime's zap options in non-test source. Development mode, inherited from the kubebuilder scaffold by thirty-one binaries, logs console text at debug level in production and makes DPanic panic. The error names that cost and points to the zap-devel flag, which still turns development mode on for local runs.
Test plan
🤖 Generated with Claude Code