Repository navigation
fix: Default zap to production mode - #2
Merged
Merged
Conversation
The operator hard-coded zap's development mode, so every controller built from this template logged console text at debug level in production and panicked on DPanic. Key changes: - stop forcing development mode; --zap-devel still enables it locally Closes #1 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
scotwells
approved these changes
Oct 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1.
Stops the operator command from forcing controller-runtime zap's development mode, so controllers built from this template log JSON at info level in production. Development mode logs console text that Loki can't parse into fields, at debug level, and makes DPanic panic. The zap-devel flag still turns it on for local runs.
Test plan
🤖 Generated with Claude Code