Skip to content

Fix port number preservation in CSS import URI resolution #432

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
martinnormark merged 1 commit into from
Jun 26, 2025
Merged

Fix port number preservation in CSS import URI resolution #432

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 18 additions & 0 deletions PreMailer.Net/PreMailer.Net.Tests/ImportRuleCssSourceTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -203,6 +203,24 @@ public void ItShould_HandleCircularImports_WithoutInfiniteLoop()
_webDownloader.Verify(w => w.DownloadString(It.Is<Uri>(u => u.ToString() == "https://a.com/circular2.css")), Times.Once);
}

[Fact]
public void ItShould_PreservePortNumber_WhenResolvingRelativeImports()
{
var baseUri = new Uri("https://localhost:8080/styles/main.css");
var css = "@import \"variables.css\";";
var variablesCss = "body { color: red; }";

_webDownloader
.Setup(w => w.DownloadString(It.Is<Uri>(u => u.ToString() == "https://localhost:8080/styles/variables.css")))
.Returns(variablesCss);

var sut = new ImportRuleCssSource();

var result = sut.GetCss(baseUri, css).ToList();

_webDownloader.Verify(w => w.DownloadString(It.Is<Uri>(u => u.ToString() == "https://localhost:8080/styles/variables.css")), Times.Once);
}

private string CreateCss(IEnumerable<string> imports)
{
var builder = new StringBuilder();
Expand Down
1 change: 0 additions & 1 deletion PreMailer.Net/PreMailer.Net/Sources/ImportRuleCssSource.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,6 @@ private static Uri GetBaseUri(Uri downloadUri)
{
var baseUrl = new UriBuilder(downloadUri)
{
Port = -1 /* Excludes the port number */,
Query = string.Empty
};

Expand Down