Fix issue #235: Preserve base64 encoded images and URLs during CSS parsing and style application#429
Merged
martinnormark merged 2 commits intomainfrom May 24, 2025
Conversation
…rsing and style application Co-Authored-By: m@martinnormark.com <m@martinnormark.com>
Contributor
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
Co-Authored-By: m@martinnormark.com <m@martinnormark.com>
martinnormark
approved these changes
May 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix issue #235: Preserve base64 encoded images and URLs during CSS parsing and style application
Issue
When using
PreMailer.MoveCssInlinewith CSS containing base64 encoded images or SVG+XML data in URLs, the data gets truncated during processing. Additionally, quoted URLs get HTML escaped, resulting in"in the output.Changes
Modified the regex pattern in
CssParser.csthat handles data URLs to properly preserve base64 content:Updated
StyleClassApplier.csto preserve original quotes in data URLs:Added comprehensive test cases in
Base64UrlTests.csto verify:==) endingTesting
All tests pass, including the new test cases that verify base64 data is preserved correctly.
Link to Devin run: https://app.devin.ai/sessions/fadfd33a7ae44b67a5c5d87c24a73045
Requested by: m@martinnormark.com