Adding support for PHP 8.0+ while removing support for PHP 5.x#1
Open
slapo wants to merge 7 commits intomilindsingh:masterfrom
Open
Adding support for PHP 8.0+ while removing support for PHP 5.x#1slapo wants to merge 7 commits intomilindsingh:masterfrom
slapo wants to merge 7 commits intomilindsingh:masterfrom
Conversation
added 7 commits
September 9, 2025 11:39
…ed without the main Barcode class if desired.
9.6, which is the last version supported for PHP 7.x. Adding type hints where missing and using constants from the new value class BarcodeType.
…guity and more clearly demonstrate comparison intent.
…ut current implementation to Overview and its content for improved clarity.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added support for PHP 8.0+ while removing support for PHP 5.x.
Even PHP 7.x is now unsupported, but I'm leaving it there to make migration from 7.x to 8.x easier (my current scenario).
To facilitate this, I also upgraded PHPUnit to the last version that supported 7.x and made the necessary changes to support the move.
Extracted types into its own value object for easier re-use while deprecating old ones, and making them aliases to the BarcodeType entries.
Slightly refactored the barcode class to reduce nesting and allow for stricter typing with fewer implicit conversions.
Updated README to reflect the changes.
Removed a now antiquated PHP 7 readiness badge.