Skip to content

refactor(channels): anti-slop cleanup for task conversations #538

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
milind-soni merged 3 commits into from
Aug 29, 2026
Merged

refactor(channels): anti-slop cleanup for task conversations #538

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
97f1e9b
refactor(channels): clean task boundaries
milind-soni Aug 28, 2026
118c17b
Merge main and preserve channel lifecycle semantics
milind-soni Aug 29, 2026
b33a004
Merge remote-tracking branch 'origin/main' into codex/anti-slop-chann…
milind-soni Aug 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion apps/docs/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@
"@types/node": "^26.2.0",
"@types/react": "^19.2.18",
"@types/react-dom": "^19.2.4",
"oxlint": "^1.78.0",
"oxlint": "1.80.0",
"postcss": "^8.5.26",
"tailwindcss": "^4.3.3",
"typescript": "^6.0.3"
Expand Down
4 changes: 2 additions & 2 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,7 @@
"zod": "4.4.3"
},
"devDependencies": {
"@oxlint/plugins": "1.78.0",
"@oxlint/plugins": "1.80.0",
"@tailwindcss/vite": "^4.1.11",
"@types/node": "^26.2.0",
"@types/react": "^19.1.9",
Expand All @@ -101,7 +101,7 @@
"electron-builder": "^26.15.3",
"electron-updater": "^6.8.9",
"esbuild": "^0.28.2",
"oxlint": "1.78.0",
"oxlint": "1.80.0",
"tailwindcss": "^4.1.11",
"typebox": "1.3.7",
"typescript": "^5.8.3",
Expand Down
176 changes: 88 additions & 88 deletions pnpm-lock.yaml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

9 changes: 9 additions & 0 deletions server/group-tasks.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,6 +84,15 @@ describe("channel tasks", () => {
expect(store.deleteGroupTask(channel.id, first)).toBeNull();
});

it("normalizes a supplied task title at the store boundary", async () => {
const { store } = await freshStore();
const bot = store.createBot();
const channel = store.createGroup("Product", [bot.id]);
const longTitle = "x".repeat(100);

expect(store.createGroupTask(channel.id, ` ${longTitle} `)?.title).toBe(longTitle.slice(0, 80));
});

it("adopts a legacy channel thread without losing its folder or pin", async () => {
const { store, Store } = await freshStore();
const bot = store.createBot();
Expand Down
1 change: 1 addition & 0 deletions server/index.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -729,6 +729,7 @@ describe("harness HTTP API", () => {
expect(removed.body.group.tasks).toHaveLength(1);
expect((await api("DELETE", `/api/groups/${room.id}/tasks/${originalThread}`)).status).toBe(400);
expect((await api("POST", `/api/groups/${room.id}/tasks/missing-thread`)).status).toBe(404);
expect((await api("POST", `/api/groups/${room.id}/tasks`, { title: 42 })).status).toBe(400);
} finally {
await api("DELETE", `/api/groups/${room.id}`);
await api("DELETE", `/api/bots/${bot.id}`);
Expand Down
Loading
Loading