Skills card: review-gated import UI for Agent Skills - #431
Open
milind-soni wants to merge 1 commit into
Open
Conversation
The UI half of the skill import: a Skills card in the bot settings panel, shaped like the Memory card (fetch on expand, same tokens). - list: name, description, enable switch, remove; warning badge when the scan flagged anything; provenance line (source + sha256 prefix) - import: paste owner/repo or a GitHub URL; imports land disabled and the first one opens straight into review - review: the full SKILL.md as PLAIN TEXT (imported content is never markdown-rendered), warnings and skipped files above the text, and Enable at the end of the read — enabling stays an explicit human act Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Warning Review limit reachedNext included review available in 13 minutes. View limit detailsLimit details: You’ve used all 10 included reviews currently available. Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. Review configuration: ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (3)
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
UI half of the skill-import feature (server landed in #428). A Skills card in bot settings, mirroring the Memory card's patterns: list with enable switches, warning badges and provenance (source + sha8), import by pasted owner/repo or GitHub URL, and a review expansion that renders the fetched SKILL.md as plain text (imported content is untrusted — never markdown-rendered) with warnings and skipped files on top, before the explicit Enable.
Built as a cherry-pick of the UI commit that followed #428's squash-merge. Typecheck clean, oxlint zero findings on touched files, 5 pure-function tests in the repo's harness style, full suite green.
Not verified: pixel appearance in the running app — no DOM-render test precedent exists in the repo.
🤖 Generated with Claude Code