This repository was archived by the owner on May 21, 2026. It is now read-only.
fix: Rate limit timer was never created due to inverted logic#488
Open
rmdes wants to merge 7 commits into
Open
fix: Rate limit timer was never created due to inverted logic#488rmdes wants to merge 7 commits into
rmdes wants to merge 7 commits into
Conversation
reamaining 1 Including the just-posted item in the calculation ensures the spacing window accounts for all posts in the sequence, which is especially important for small queues where the difference between dividing by 2 versus 3 significantly affects the delay.
Some websites return og:url values like 'https//example.com' (missing colon after protocol). These get treated as relative URLs and concatenated with the base URL, creating broken links. This fix: - Adds fixMalformedUrl() to correct 'https//' -> 'https://' - Improves URL validation regex to require proper protocol - Validates the corrected URL before using it
created because rateLimited starts as false. This meant rate limits were never properly respected - the queue would keep retrying every runInterval instead of waiting for the rate limit to expire. Fixed by inverting the condition to `if (rateLimited) return` which correctly prevents duplicate timers while allowing the first timer to be created.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug
The rate limit timer was never being created due to inverted logic in
createLimitTimer():Impact
When hitting Bluesky's rate limit, the queue would:
Fix
Testing
Observed in production logs where a queue with 2791 items kept hitting rate limits every 60 seconds indefinitely, instead of properly backing off.