This repository was archived by the owner on May 21, 2026. It is now read-only.
fix: handle malformed og:url protocols missing colon#487
Open
rmdes wants to merge 1 commit into
Open
Conversation
Some websites return og:url values like 'https//example.com' (missing colon after protocol). These get treated as relative URLs and concatenated with the base URL, creating broken links. This fix: - Adds fixMalformedUrl() to correct 'https//' -> 'https://' - Improves URL validation regex to require proper protocol - Validates the corrected URL before using it
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some websites return og:url values like 'https//example.com' (missing
colon after protocol). These get treated as relative URLs and
concatenated with the base URL, creating broken links.
This fix:
Problem
Some websites have malformed
og:urlmeta tags likehttps//example.com(missing the colon after the protocol). When the Open Graph scraper encounters this, it treats it as a relative URL and resolves it against the base URL, creating broken links like:https://www.lecho.behttps//www.lecho.be/pathExample of affected post: https://bsky.app/profile/polbegov.skyfleet.blue/post/3maw2bc3deb25
Root Cause
The malformed
og:url(e.g.,https//www.lecho.be/path) doesn't match the protocol pattern, so URL resolution treats it as a relative path and prepends the base domain.Solution
Added
fixMalformedUrl()function that corrects common protocol typos:https//→https://http//→http://Improved the URL validation regex: