Repository navigation
fix: reject malformed exact-replay path values without exceptions - #219
Merged
Merged
Conversation
This was referenced Oct 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ExactReplay validation recorded a non-string fixed path type error, then still called JsonElement.GetString and threw for numbers, booleans, arrays and objects. Use the existing successful type check as the condition for path parsing, returning the normal scenario_invalid response on malformed values. Closes #217; child of #210.
One production line changes. Existing valid-string and unsafe-string path rules are preserved, and no output file is accessed. Regression coverage includes both filePath/directoryPath, all non-string JSON literal kinds, ValidateDraft/Save refusal before persistence and validation of stored malformed values.
Validation: ten new cases fail with exceptions before the change; two null-value cases already reject normally. All 83 scenario tests pass after the change (12 new cases), zero skips/warnings. Tool-less Claude review completed without blocking findings; Codex verified the change and added an assertion that type-invalid values do not produce an absolute-path parsing error. Null now returns the type error alone instead of the previous type-plus-path error. Final SHA 3da1e90 passed Release2024/2025/2026/2027 x64 L2; Both CI runs 37191932745 / 37191910745 passed with 2,441 tests, zero skips and all catalog/stdin/distribution guards. No Navisworks runtime claim.