Repository navigation
fix: complete MCP schema reference and copy validation - #218
Merged
Merged
Conversation
This was referenced Oct 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Complete the remaining normalizer boundaries recorded after #214: recognize contentSchema as a schema slot, reject unresolved direct definition references, and normalize boolean subschemas in copies selected from instance data. An independent visited-reference set keeps direct recursive definitions finite without rewriting compatible pointers. Original annotation/instance values remain untouched. Closes #215; child of #210.
Scope stays local-only: no remote fetching, anchors, new dialect engine or public MCP tool changes. contentSchema is a schema-valued keyword in the JSON Schema documentation.
Validation: seven new cases fail before implementation; all 47 normalizer tests pass after it (nine new cases), zero skips/warnings. Tests cover contentSchema/data separation, missing/escaped direct definition references, mutual recursion, copied true/false schemas and idempotence. Tool-less Claude review completed without actionable regressions; Codex checked the reasoning against the source and tests. Mutual recursion and false-copy tests are forward guards, not part of the seven reproduced failures. Final SHA 894c277 passed Release2024/2025/2026/2027 x64 L2 and both CI runs 37191665305 / 37191645794, including catalog/stdin checks and 2,429 tests with zero skips. No Navisworks runtime claim.