Skip to content

Add checks to subset_*() commands #54

Description

@mikemc

Currently, no warning is given for typos such as subset_taxa(ps, phylum = "Bacteroidetes"). Instead, this command will simply run and not filter out anything. Contrast with dplyr::filter(), which gives a helpful error message suggesting to use == instead of =.

Adding such behavior seems unambiguously beneficial, but there is perhaps some value in the simplicity of keeping the subset_ commands as simple wrappers around base::subset().

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or requestquestionFurther information is requested

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions