FEAT: Added distinct_id to new_page_view and new_event#16
Open
ddxv wants to merge 3 commits into
Open
Conversation
Contributor
Author
|
Also, AI threw in a section in the change log, which I can remove if you prefer to handle that differently / not in this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This seemed to work find in my testing for page views. The distinct id can be an string (final output) or an integer (coerced to string).
This was related to #13 which was previously closed as completed. If this is out of scope of the project / implemented in a way i missed, just let me know / close the PR.