Skip to content

Read and answer design reviews on the iPhone - #73

Closed
waynesutton wants to merge 4 commits into
mikecann:mainfrom
waynesutton:pr/mobile-design-reviews
Closed

waynesutton wants to merge 4 commits into
mikecann:mainfrom
waynesutton:pr/mobile-design-reviews

Conversation

@waynesutton

@waynesutton waynesutton commented Nov 17, 2026 •

Copy link
Copy Markdown
Contributor

A thread can ask for a design decision on the iPhone while its options are only visible on the Mac. This adds a Reviews sheet, opened from the thread toolbar or a review: link, so the user can inspect the choices and answer from the phone.

The sheet shows recommended and reference options, shot titles, still previews, multiple selections, None of these, per-option notes and a reply. Loading and failed submissions keep the draft. Pages and videos are labeled as still previews; their interactive originals remain on the Mac.

The phone uses authenticated backend API 83 commands routed to the owning runner. Answers reuse reviews.respond, including revision checks, reference validation and duplicate-response protection. Commands forward to a draining runner during handover. Preview lookup adds an index to the existing private reply-image table; the phone receives opaque sources instead of local file paths. No new table or third-party dependency is added.

Validation:

  • Runner and Convex TypeScript checks pass.
  • 58 focused runner/backend tests pass, including a real runner → backend validators → phone command → runner scenario.
  • 12 Swift model/link tests pass.
  • Two focused handover tests pass.
  • All seven GitHub checks pass for the implementation commit: runner/backend tests on macOS and Ubuntu, both Mac Xcode builds, and the iPhone build.
  • Local arm64 iOS simulator build passes. The dark review sheet was visually inspected with synthetic previews, recommendation, reference option, choice control and notes field.
  • Simulator taps, scrolling and submission/error UI were not manually exercised. The focused tests cover response validation, stale revisions and duplicate responses.

Requires the updated iPhone app, runner and backend. No deployment or phone installation has been performed. No screenshot or private transcript is included.

@waynesutton
waynesutton marked this pull request as ready for review November 17, 2026 01:04
mikecann added a commit that referenced this pull request Nov 18, 2026
The phone's Reviews sheet, from the thread's top bar or a review: link:
options, notes and stills, picks, none, per-option notes and a reply,
answered through the thread's runner with the Mac's revision checks.

Rewritten from Wayne Sutton's PR #73 on today's main, with changes:
backend API 86 (83 was taken); a draft's pasted pictures (local paths)
never go to the phone and an answer from it can't carry any; a review's
stills go up only once the phone opens it, with no backfill at start;
a still over 10 MB or in another format is shrunk to a JPEG, and one that
can't go says so instead of waiting; a short review: id finds answered
reviews too; and the answer's notes go as a list, as Convex refuses
object keys that aren't plain ASCII or start with $.

Co-Authored-By: Wayne Sutton <waynesutton@users.noreply.github.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@mikecann

Copy link
Copy Markdown
Owner

Hey @waynesutton thanks heaps for this one, really nice idea being able to answer design reviews from the phone.

Main had moved on quite a bit since you made it so I had my agent rebuild it on top of main rather than merge it, and its now in with you as co-author on each commit: 907403c, 43a7973 and 455a5bd.

A few things it changed along the way:

  • its on backend API 86 as 83 had already been taken
  • pictures pasted into a review on the Mac don't go to the phone, so no local file paths end up in Convex
  • a review's stills only upload when you open it on the phone, rather than for every review
  • big stills get shrunk to a JPEG, and if one can't be sent the sheet says so rather than waiting forever

So im going to close this one, thanks again mate!

Cheers,

@mikecann mikecann closed this Nov 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants