Repository navigation
Port resizable component to react-resizable-panels v4 - #476
Merged
Merged
Conversation
v4 renamed PanelGroup to Group and PanelResizeHandle to Separator, and replaced the data-panel-group-direction attribute with aria-orientation. The shadcn wrapper still used the v3 names, so it failed to type-check and would render undefined components. This matches shadcn's current v4 registry version of the component. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info
📝 Walkthrough
Merge Risk: ⚪ Minimal · up to
|
| Check name | Status | Explanation | Resolution |
|---|---|---|---|
| Docstring Coverage |  |
Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 3 functions across 1 files. | Write docstrings for the functions missing them to satisfy the coverage threshold. |
-
Check name Status Explanation Description Check Check skipped - CodeRabbit’s high-level summary is enabled. Title check The title clearly and concisely describes the main change: updating the resizable component to the react-resizable-panels v4 API. Linked Issues check Check skipped because no linked issues were found for this pull request. Out of Scope Changes check Check skipped because no linked issues were found for this pull request.
- Fix all pre-merge checks with AI
✨ Finishing Touches: 💡 1
-
📝 Generate docstrings: 💡
-
- Commit to this branch
- Create a new PR
🧪 Generate unit tests (beta)
-
- Commit to this branch
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Comment @coderabbitai help to get the list of available commands.
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #470. The
resizablewrapper inpackages/uistill used the react-resizable-panels v3 API while the repo is on v4.v4 renamed the primitives, and this PR updates the wrapper to match:
PanelGroupis nowGroup, andPanelResizeHandleis nowSeparator.GroupProps,PanelPropsandSeparatorProps.aria-orientationinstead ofdata-panel-group-direction.The result matches shadcn's current v4 registry version, kept in this repo's formatting.
No app imports this component today, so nothing on the live sites changes.
Verification:
vp checkno longer reports the three missing-export warnings for this file.tsconpackages/uino longer reports the five errors in this file. The eight remaining errors are pre-existing ones inchart.tsx.🤖 Generated with Claude Code
Summary by CodeRabbit