Move abort operation from ISession to ITurn#9
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
ITurn) instead of the whole session (ISession).Description
abort(): Promise<void>toITurnand removedabort()fromISessionin the public API (packages/api/src/index.tsandspecs/api.md).AgentSessionDOto constructTurnImplwith an abort delegate (#abortCurrentTurn) and removed the session-level forwarder forabort()inSessionTarget(packages/core/src/agent-session-do.ts).TurnImpl.abort()which invokes the DO's abort delegate to cancel the active turn stream.session.getCurrentTurn()and callsturn?.abort(); Telegram/abortand gateway examples inspecs/gateway.mdandspecs/telegram_gateway.mdwere updated to callgetCurrentTurn()?.abort().ITurnincludesabort(), core mocks removedISession.abort()no-op, and in-DO tests now callgetCurrentTurn()?.abort()where appropriate).Testing
pnpm -C packages/core test, all tests passed (314tests passed).pnpm -C gateways/web test, all tests passed (3tests passed).Codex Task