Add pyfia.carbon: NSVB-based forest carbon estimation (all 6 IPCC pools + stock-change)#83

Merged

mihiarc merged 30 commits into

mihiarc:mainfrom

ctrees-products:main

May 11, 2026

Commits on Apr 8, 2026

Add NSVB equation library and coefficient loaders for pyfia.carbon Phase 1

authored and
Chris Mihiar
committed

Commits on Apr 9, 2026

Address PR 1 review blockers and document PR 2 contract

authored and
Chris Mihiar
committed
Lock all 5 NSVB coefficient CSVs in TestPipelineViaCSV sentinels

Chris Mihiar
and
claude
committed
Merge pull request #1 from ctrees-products/feat/carbon-nsvb-equations
mihiarc
authored
Add NSVB live tree carbon estimator (pyfia.carbon.live_tree)

Chris Mihiar
and
claude
committed
Apply PR 2 critical-review fixes before real-data validation

Chris Mihiar
and
claude
committed
Fix SPCD dtype cast and conftest teardown guard

Chris Mihiar
and
claude
committed
Add live_tree NSVB vs FIADB parity validation (scaffolding + baseline)

Chris Mihiar
and
claude
committed
Merge pull request #2 from ctrees-products/feat/carbon-nsvb-live-tree-estimator
mihiarc
authored
Implement Phase 1.5 DIVISION lookup; close growing-stock biomass gap

Chris Mihiar
and
claude
committed
Add PLOTGEOM to COMMON_TABLES; reconcile carbon roadmap for Phase 1.6/1.7

Chris Mihiar
and
claude
committed
Phase 1.7: thread ECOSUBCD through LiveTreeEstimator

Chris Mihiar
and
claude
committed
Phase 1.6: scope validation test to EVALID 132401

Chris Mihiar
and
claude
committed
Bump uv.lock to revision 3 format

Chris Mihiar
and
claude
committed

Commits on Apr 10, 2026

Implement Phase 2 standing dead carbon pool; update docs

Chris Mihiar
and
claude
committed
Fix DECAYCD empty-string filter leak; export dead-tree functions from nsvb

Chris Mihiar
and
claude
committed
Merge PR 3: NSVB carbon pools (live tree + standing dead) with validation gates
mihiarc
authored
Broken-top corrections for standing dead; extract CarbonEstimatorBase; close all PR 3 review warnings

Chris Mihiar
and
claude
committed

Commits on Apr 13, 2026

Implement Phase 4 condition-level carbon pools and total_ecosystem

Chris Mihiar
and
claude
committed
Address PR review: empty-result guard, CONDPROP comment, total_ecosystem tests

Chris Mihiar
and
claude
committed
Merge PR 4: Phase 4 condition-level carbon pools + total_ecosystem
mihiarc
authored
Implement condition-level carbon stock-change accounting (Phase A)

Chris Mihiar
and
claude
committed
Update carbon docstring: add stock_change section, update deferred list

Chris Mihiar
and
claude
committed
Address PR review: fix PREVCOND→CONDID docstrings, filter dual-NULL carbon

Chris Mihiar
and
claude
committed
Merge PR 5: Phase 5 condition-level carbon stock-change accounting
mihiarc
authored

Commits on May 5, 2026

Add NGHGI Stage A: reproduce EPA Chapter 6 Table 6-10 forest carbon stocks

Chris Mihiar
and
claude
committed
Add NGHGI multi-year validation across 2019-2023

Chris Mihiar
and
claude
committed
Add NGHGI Stage B: state-level flux validation reveals methodology divergence

Chris Mihiar
and
claude
committed

Commits on May 11, 2026

Address PR 83 review: move NGHGI report-repro to scripts/, strip grant branding, clean total_ecosystem

Chris Mihiar
and
claude
committed
Add unit tests for total_ecosystem grp_by behavior

Chris Mihiar
and
claude
committed