Skip to content

Update dependencies to recent versions - #1559

Merged
istein1 merged 1 commit into
migtools:masterfrom
awels:update_dependencies
Jul 9, 2026
Merged

Update dependencies to recent versions#1559
istein1 merged 1 commit into
migtools:masterfrom
awels:update_dependencies

Conversation

@awels

@awels awels commented Jul 8, 2026

Copy link
Copy Markdown
Contributor

Summary by CodeRabbit

  • Bug Fixes
    • Reduced noisy build warnings during local development.
  • Chores
    • Updated the local development server configuration and start command for improved compatibility and stability.
    • Refreshed dependency versions and resolution overrides to improve development reliability.
    • Expanded allowed local tool access for external web requests and common Yarn commands.

@coderabbitai

coderabbitai Bot commented Jul 8, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 0b1d1fd6-5bd2-469c-9950-2e3235175cbd

📥 Commits

Reviewing files that changed from the base of the PR and between b99b2c1 and 6d72989.

⛔ Files ignored due to path filters (1)
  • yarn.lock is excluded by !**/yarn.lock, !**/*.lock
📒 Files selected for processing (3)
  • .claude/settings.local.json
  • config/webpack.dev.js
  • package.json
💤 Files with no reviewable changes (1)
  • .claude/settings.local.json
🚧 Files skipped from review as they are similar to previous changes (2)
  • package.json
  • config/webpack.dev.js

📝 Walkthrough

Walkthrough

This PR updates webpack dev warning suppression, removes a dev-server CLI flag, upgrades webpack-dev-server, and expands dependency resolutions in package.json.

Changes

Dev environment and dependency updates

Layer / File(s) Summary
Webpack dev warning suppression
config/webpack.dev.js
Moves missing-export warning filtering to top-level ignoreWarnings and removes the previous devServer.devMiddleware.stats.warningsFilter block.
Package.json dev-server and resolutions update
package.json
Removes --info=true from the start script, upgrades webpack-dev-server to ^5.2.5, and adds several new resolution overrides.

Estimated code review effort: 2 (Simple) | ~10 minutes

Suggested reviewers: ibolton336

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately summarizes the main change: dependency updates to newer versions.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 ESLint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

ESLint install failed. For unrecoverable errors, disable the tool in CodeRabbit configuration.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

"Bash(yarn list:*)",
"Bash(yarn info:*)",
"Bash(yarn test:*)",
"Bash(yarn ci:*)"

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this file shouldn't be committed. It's a local Claude Code config file, no ?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is, but it was already in the repository. I was a little confused as well. I did make a change to it, I can revert that if you prefer, or remove the file completely as I don't think it should actually be here.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay removed the file, it should not be there.

Comment thread yarn.lock

"node-forge@npm:^1":
version: 1.3.1
resolution: "node-forge@npm:1.3.1"

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

here node-forge 1.3.1 is removed from yarn.lock, is this package no longer used, or should it be upgraded to >= 1.3.2 to fix CVE-2025-12816 and CVE-2025-66031 ?
there are 2 jira tickets related to this

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes node-forge has been removed, if you look at the webpack-dev-server 5.x upgrade output, selfsigned the only package that depended on node-forge was removed. So it is no longer needed.

Signed-off-by: Alexander Wels <awels@redhat.com>
@awels
awels force-pushed the update_dependencies branch from b99b2c1 to 6d72989 Compare July 8, 2026 20:02

@midays midays left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@istein1
istein1 merged commit d4f2d13 into migtools:master Jul 9, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants