Update dependencies to recent versions - #1559
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (3)
💤 Files with no reviewable changes (1)
🚧 Files skipped from review as they are similar to previous changes (2)
📝 WalkthroughWalkthroughThis PR updates webpack dev warning suppression, removes a dev-server CLI flag, upgrades ChangesDev environment and dependency updates
Estimated code review effort: 2 (Simple) | ~10 minutes Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 ESLint
ESLint install failed. For unrecoverable errors, disable the tool in CodeRabbit configuration. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
| "Bash(yarn list:*)", | ||
| "Bash(yarn info:*)", | ||
| "Bash(yarn test:*)", | ||
| "Bash(yarn ci:*)" |
There was a problem hiding this comment.
this file shouldn't be committed. It's a local Claude Code config file, no ?
There was a problem hiding this comment.
It is, but it was already in the repository. I was a little confused as well. I did make a change to it, I can revert that if you prefer, or remove the file completely as I don't think it should actually be here.
There was a problem hiding this comment.
Okay removed the file, it should not be there.
|
|
||
| "node-forge@npm:^1": | ||
| version: 1.3.1 | ||
| resolution: "node-forge@npm:1.3.1" |
There was a problem hiding this comment.
here node-forge 1.3.1 is removed from yarn.lock, is this package no longer used, or should it be upgraded to >= 1.3.2 to fix CVE-2025-12816 and CVE-2025-66031 ?
there are 2 jira tickets related to this
There was a problem hiding this comment.
yes node-forge has been removed, if you look at the webpack-dev-server 5.x upgrade output, selfsigned the only package that depended on node-forge was removed. So it is no longer needed.
Signed-off-by: Alexander Wels <awels@redhat.com>
b99b2c1 to
6d72989
Compare
Summary by CodeRabbit