Resolve Clip Count Display Inaccuracy & Delete Clip Display - #14
Open
mfisher31 wants to merge 3 commits into
Open
Resolve Clip Count Display Inaccuracy & Delete Clip Display#14mfisher31 wants to merge 3 commits into
mfisher31 wants to merge 3 commits into
Conversation
…on aliases. fixes: clip-counter badge always displaying "0"
- Add deleted/deleted_at fields to TimelineEntry Rust struct so serde no longer silently drops them when round-tripping through save_project_timeline - Fix saveTimeline in ClipsList to merge backend entries not present in current React state, preventing previously-deleted clips from being dropped and then re-added as orphans by reconcile
- Fix get_projects to count active (non-deleted) entries directly from timeline entries rather than trusting stale metadata.total_videos - Pass refreshProjects as onClipsUpdate in ProjectPanel so badge updates after delete without triggering infinite reload loop - Remove onClipsUpdate call from initial loadClips to prevent refresh cycle; callback now only fires after mutations (delete)
mfisher31
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes clip count drift and soft-delete persistence across refreshes, reconciles, and project changes.
Closes #5
Closes #4
Changes
deletedanddeletedAton timeline entries in the Rust backendResult
Validation
cargo check --manifest-path src-tauri/Cargo.tomlpassed