Repository navigation
hotfix: restore web landing page (skip device check on browsers) - #437
Merged
Merged
Conversation
fix: restore web landing page (skip device check on browsers)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The v1.5.3 registration hotfix leaves web browsers waiting for a Cordova device UUID that never arrives. After the 10s loading timeout, the public website (mieauth-prod.os.mieweb.org) shows the Connection Issues screen instead of the landing page.
Fix
Skip the device registration check when not running under Cordova (PR #436, merged to development as dev-v1.5.4). Web visitors immediately render WebLandingPage; mobile behavior is unchanged.
Impact
Deployment note
Server deploy also delivers this to installed v1.5.3 apps via Meteor hot code push — no new store binaries required for the immediate fix.