Repository navigation
hotfix: prevent false device registration resets - #435
Merged
Merged
Conversation
Treat registration lookup failures and missing device identity as indeterminate states instead of routing users to onboarding.
fix: prevent false device registration resets
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Production incident
v1.5.2 can interpret a failed device-registration lookup as an unregistered device, routing an existing user into onboarding and making their registration appear lost.
Hotfix
Included changes
Validation
Deployment note
This PR is intentionally not merged. Merge only after review and production release approval.